Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage Blob] Request breaks when blob_name has a '~' character. #7407

Closed
rakshith91 opened this issue Sep 23, 2019 · 1 comment
Closed

[Storage Blob] Request breaks when blob_name has a '~' character. #7407

rakshith91 opened this issue Sep 23, 2019 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@rakshith91
Copy link
Contributor

rakshith91 commented Sep 23, 2019 •
edited by lmazuel
Loading

The latest version of urllib3 (1.25.4) encodes ~ as %7E. This breaks the request since the Storage signing service refuses to accept %7E instead of ~.

Issue in urllib3 to track: urllib3/urllib3#1683

Acceptability Criteria:
Fix this and uskip this test.
@rakshith91 rakshith91 mentioned this issue Sep 23, 2019
Merged
@kurtzeborn kurtzeborn mentioned this issue Sep 23, 2019
Closed
23 tasks
@lmazuel lmazuel added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Sep 23, 2019
@lmazuel lmazuel mentioned this issue Sep 23, 2019
Merged
@lmazuel
Copy link
Member

lmazuel commented Sep 24, 2019

Fixed in urllib 1.25.6

@lmazuel lmazuel closed this as completed Sep 24, 2019
@rakshith91 rakshith91 mentioned this issue Sep 26, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmazuel @rakshith91