Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement autorest x-ms extensions #7403

Closed
lmazuel opened this issue Sep 23, 2019 · 1 comment
Closed

Implement autorest x-ms extensions #7403

lmazuel opened this issue Sep 23, 2019 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation

Comments

@lmazuel
Copy link
Member

lmazuel commented Sep 23, 2019

x-ms-extensions are defined here:
https://github.com/Azure/autorest/blob/master/docs/extensions/readme.md

We need to re-implement them in Autorest v3 generators.

Assuming remodeler passes the metadata, this is the extensions I believe are language specific:

  • x-ms-skip-url-encoding
  • x-ms-enum
  • x-ms-client-flatten
  • x-ms-parameterized-host
  • x-ms-error-response
  • x-ms-odata (Python doesn't plan to support)
  • x-ms-azure-resource (ARM specific)

I expect the remodeler to do something about it:

  • x-ms-parameter-grouping (should create the group in the YAML)
  • x-ms-parameter-location (should be in the right place in the YAML)
  • x-ms-paths (should be a regular path on consumption)
  • x-ms-client-name (new field preferred name: name from Swagger or x-ms-client-name)
  • x-ms-discriminator-value (new field preferred value: value from Swagger or x-ms-disc-value)

Needs to be discussed if we drop support:

  • x-ms-external
  • x-ms-mutability
  • x-ms-request-id
  • x-ms-client-request-id

Dedicated issues:

@lmazuel lmazuel added Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation labels Sep 23, 2019
@lmazuel lmazuel self-assigned this Sep 23, 2019
@lmazuel
Copy link
Member Author

lmazuel commented Apr 13, 2020

Done

@lmazuel lmazuel closed this as completed Apr 13, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation
Projects
None yet
Development

No branches or pull requests

1 participant