Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor black check to be configured in pyproject.toml instead of ci.yml #35153

Closed
kristapratico opened this issue Apr 11, 2024 · 0 comments · Fixed by #38212
Closed

refactor black check to be configured in pyproject.toml instead of ci.yml #35153

kristapratico opened this issue Apr 11, 2024 · 0 comments · Fixed by #38212
Assignees
Labels
Client This issue points to a problem in the data-plane of the library.

Comments

@kristapratico
Copy link
Member

black formatting is currently opt-in by specifying ValidateFormatting: true in a library's ci.yml: https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#opt-in-to-formatting-validation

We should refactor this check to instead be turned on/off by the pyproject.toml where other checks like pylint, mypy, pyright, and sphinx are controlled.

@kristapratico kristapratico added the Client This issue points to a problem in the data-plane of the library. label Apr 11, 2024
@kristapratico kristapratico self-assigned this Apr 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant