Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opentelemetry] correct sample slug in sample READMEs #17991

Closed
kristapratico opened this issue Apr 12, 2021 · 1 comment
Closed

[opentelemetry] correct sample slug in sample READMEs #17991

kristapratico opened this issue Apr 12, 2021 · 1 comment
Assignees
@rakshith91
Labels
blocking-release Blocks release Docs Monitor - Exporter Monitor OpenTelemetry Exporter
Milestone
[2021] May

Comments

@kristapratico
Copy link
Member

kristapratico commented Apr 12, 2021 •
edited
Loading

The sample slugs (the metadata under products) for azure-core-tracing-opentelemetry and azure-monitor-opentelemetry-exporter do not match any of the valid options found here:
https://review.docs.microsoft.com/en-us/help/contribute/metadata-taxonomies?branch=master#product

These need to be updated so that samples publish correctly.
@kristapratico kristapratico added the Monitor - Exporter Monitor OpenTelemetry Exporter label Apr 12, 2021
@kristapratico kristapratico changed the title [opentelemetry] correct sample slug in sample README [opentelemetry] correct sample slug in sample READMEs Apr 13, 2021
@rakshith91 rakshith91 added this to the [2021] May milestone Apr 13, 2021
@rakshith91 rakshith91 added the blocking-release Blocks release label Apr 13, 2021
@heaths
Copy link
Member

heaths commented Apr 15, 2021

I've had to remove this line from core for now as it was blocking a merge.

heaths added a commit that referenced this issue Apr 15, 2021
@heaths
Remove invalid 'telemetry' product slug
11fd9ef 
Relates to #17991
@heaths heaths mentioned this issue Apr 15, 2021
Closed
azure-sdk added a commit that referenced this issue Apr 15, 2021
@azure-sdk @heaths
Sync eng/common directory with azure-sdk-tools for PR 1559 (#18064)
f394ae8 
* Handle empty files in Test-SampleMetadata

Relates to Azure/azure-sdk-for-java#20684

* Remove condition from verify-samples

* Use forward slash in path

* Fix directory typo

* Remove invalid 'telemetry' product slug

Relates to #17991

* Disable verify-samples template

Opened #18066 to track re-enabling it.

Co-authored-by: Heath Stewart <heaths@microsoft.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Apr 27, 2022
CodeGen from PR 17991 in Azure/azure-rest-api-specs
7a5398e 
add xms-ids for providerhub (Azure#17991)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rakshith91 rakshith91

Labels
blocking-release Blocks release Docs Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Milestone
[2021] May
Development

No branches or pull requests
3 participants
@heaths @rakshith91 @kristapratico