Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Event Grid samples are not showing up in docs.microsoft.com/samples/browse #17895

Closed
ramya-rao-a opened this issue Apr 8, 2021 · 3 comments · Fixed by #17945
Closed

[BUG] Event Grid samples are not showing up in docs.microsoft.com/samples/browse #17895

ramya-rao-a opened this issue Apr 8, 2021 · 3 comments · Fixed by #17945
Assignees
@rakshith91
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Docs Event Grid Messaging Messaging crew
Milestone
[2021] May

Comments

@ramya-rao-a
Copy link
Contributor

We expect all the samples that live in this repo to show up in https://docs.microsoft.com/samples/browse
We do this by adding the right metadata in the readme file that lives in the folder that has the samples.

If you see this search query for Event Grid samples in Python, there are no results for samples for Event Grid SDK

Compare this with the [search query for Event Grid samples in JS]https://docs.microsoft.com/en-us/samples/browse/?filter-products=grid&products=azure-event-grid&languages=javascript) and you will see samples for Event Grid SDK. Same for .NET
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 8, 2021
@kristapratico kristapratico added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Docs Event Grid and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Apr 8, 2021
@rakshith91 rakshith91 added this to the [2021] May milestone Apr 8, 2021
@rakshith91 rakshith91 mentioned this issue Apr 9, 2021
Merged
@ramya-rao-a
Copy link
Contributor Author

Can we keep this issue open until the sample actually starts showing up in docs.microsoft.com/samples/browser?

@rakshith91
Copy link
Contributor

@ramya-rao-a Verified that the samples are reflecting in the search query

Here's the link https://docs.microsoft.com/en-us/samples/azure/azure-sdk-for-python/eventgrid-samples/

@ramya-rao-a
Copy link
Contributor Author

Yay! Thanks!

@lmazuel lmazuel added the Messaging Messaging crew label Apr 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rakshith91 rakshith91

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Docs Event Grid Messaging Messaging crew
Projects
None yet
Milestone
[2021] May
Development

Successfully merging a pull request may close this issue.

samples Update README.md Azure/azure-sdk-for-python
4 participants
@lmazuel @rakshith91 @ramya-rao-a @kristapratico