Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] Track2 - Replace UTC_Now() workaround with MSRest.UTC #13405

Closed
KieranBrantnerMagee opened this issue Aug 28, 2020 · 0 comments · Fixed by #13498
Closed

[ServiceBus] Track2 - Replace UTC_Now() workaround with MSRest.UTC #13405

KieranBrantnerMagee opened this issue Aug 28, 2020 · 0 comments · Fixed by #13498
Labels
Client This issue points to a problem in the data-plane of the library. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated Service Bus
Milestone
Backlog

Comments

@KieranBrantnerMagee
Copy link
Member

We've been using a local workaround to get proper backcompat UTC behavior in SB and EH.

We should be using the shared solution instead; namely msrest.UTC

See sample here for the current (legacy) behavior.

Replace, test, deprecate old API.
@KieranBrantnerMagee KieranBrantnerMagee added Service Bus Client This issue points to a problem in the data-plane of the library. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated labels Aug 28, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the Backlog milestone Aug 28, 2020
@plooploops plooploops mentioned this issue Sep 1, 2020
Merged
@KieranBrantnerMagee KieranBrantnerMagee linked a pull request Sep 4, 2020 that will close this issue
Replace UTC_Now() workaround with MSRest.UTC #13498
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated Service Bus
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Replace UTC_Now() workaround with MSRest.UTC plooploops/azure-sdk-for-python
1 participant
@KieranBrantnerMagee