Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

[AutoPR apimanagement/resource-manager] Bug fix on readonly property #3309

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ class CertificateConfiguration {
},
certificate: {
required: false,
readOnly: true,
serializedName: 'certificate',
type: {
name: 'Composite',
Expand Down
4 changes: 2 additions & 2 deletions lib/services/apimanagement/lib/models/groupContract.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ class GroupContract extends models['Resource'] {
* 'custom', 'system', 'external'
* @member {string} [externalId] For external groups, this property contains
* the id of the group from the external identity provider, e.g. for Azure
* Active Directory aad://<tenant>.onmicrosoft.com/groups/<group object id>;
* otherwise the value is null.
* Active Directory `aad://<tenant>.onmicrosoft.com/groups/<group object
* id>`; otherwise the value is null.
*/
constructor() {
super();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ class GroupContractProperties {
* 'system', 'external'
* @member {string} [externalId] For external groups, this property contains
* the id of the group from the external identity provider, e.g. for Azure
* Active Directory aad://<tenant>.onmicrosoft.com/groups/<group object id>;
* otherwise the value is null.
* Active Directory `aad://<tenant>.onmicrosoft.com/groups/<group object
* id>`; otherwise the value is null.
*/
constructor() {
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class GroupCreateParameters {
* @member {string} [externalId] Identifier of the external groups, this
* property contains the id of the group from the external identity provider,
* e.g. for Azure Active Directory
* aad://<tenant>.onmicrosoft.com/groups/<group object id>; otherwise the
* `aad://<tenant>.onmicrosoft.com/groups/<group object id>`; otherwise the
* value is null.
*/
constructor() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class GroupUpdateParameters {
* @member {string} [externalId] Identifier of the external groups, this
* property contains the id of the group from the external identity provider,
* e.g. for Azure Active Directory
* aad://<tenant>.onmicrosoft.com/groups/<group object id>; otherwise the
* `aad://<tenant>.onmicrosoft.com/groups/<group object id>`; otherwise the
* value is null.
*/
constructor() {
Expand Down
16 changes: 9 additions & 7 deletions lib/services/apimanagement/lib/models/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1868,7 +1868,7 @@ export interface CertificateConfiguration {
encodedCertificate?: string;
certificatePassword?: string;
storeName: string;
readonly certificate?: CertificateInformation;
certificate?: CertificateInformation;
}

/**
Expand Down Expand Up @@ -2576,7 +2576,7 @@ export interface EmailTemplateUpdateParameters {
* 'system', 'external'
* @member {string} [externalId] For external groups, this property contains
* the id of the group from the external identity provider, e.g. for Azure
* Active Directory aad://<tenant>.onmicrosoft.com/groups/<group object id>;
* Active Directory `aad://<tenant>.onmicrosoft.com/groups/<group object id>`;
* otherwise the value is null.
*/
export interface GroupContractProperties {
Expand All @@ -2602,7 +2602,7 @@ export interface GroupContractProperties {
* 'custom', 'system', 'external'
* @member {string} [externalId] For external groups, this property contains
* the id of the group from the external identity provider, e.g. for Azure
* Active Directory aad://<tenant>.onmicrosoft.com/groups/<group object id>;
* Active Directory `aad://<tenant>.onmicrosoft.com/groups/<group object id>`;
* otherwise the value is null.
*/
export interface GroupContract extends Resource {
Expand All @@ -2625,8 +2625,9 @@ export interface GroupContract extends Resource {
* 'system', 'external'
* @member {string} [externalId] Identifier of the external groups, this
* property contains the id of the group from the external identity provider,
* e.g. for Azure Active Directory aad://<tenant>.onmicrosoft.com/groups/<group
* object id>; otherwise the value is null.
* e.g. for Azure Active Directory
* `aad://<tenant>.onmicrosoft.com/groups/<group object id>`; otherwise the
* value is null.
*/
export interface GroupCreateParameters {
displayName: string;
Expand All @@ -2647,8 +2648,9 @@ export interface GroupCreateParameters {
* 'system', 'external'
* @member {string} [externalId] Identifier of the external groups, this
* property contains the id of the group from the external identity provider,
* e.g. for Azure Active Directory aad://<tenant>.onmicrosoft.com/groups/<group
* object id>; otherwise the value is null.
* e.g. for Azure Active Directory
* `aad://<tenant>.onmicrosoft.com/groups/<group object id>`; otherwise the
* value is null.
*/
export interface GroupUpdateParameters {
displayName?: string;
Expand Down
24 changes: 12 additions & 12 deletions lib/services/apimanagement/lib/operations/group.js
Original file line number Diff line number Diff line change
Expand Up @@ -589,8 +589,8 @@ function _get(resourceGroupName, serviceName, groupId, options, callback) {
* @param {string} [parameters.externalId] Identifier of the external groups,
* this property contains the id of the group from the external identity
* provider, e.g. for Azure Active Directory
* aad://<tenant>.onmicrosoft.com/groups/<group object id>; otherwise the value
* is null.
* `aad://<tenant>.onmicrosoft.com/groups/<group object id>`; otherwise the
* value is null.
*
* @param {object} [options] Optional Parameters.
*
Expand Down Expand Up @@ -829,8 +829,8 @@ function _createOrUpdate(resourceGroupName, serviceName, groupId, parameters, op
* @param {string} [parameters.externalId] Identifier of the external groups,
* this property contains the id of the group from the external identity
* provider, e.g. for Azure Active Directory
* aad://<tenant>.onmicrosoft.com/groups/<group object id>; otherwise the value
* is null.
* `aad://<tenant>.onmicrosoft.com/groups/<group object id>`; otherwise the
* value is null.
*
* @param {string} ifMatch ETag of the Entity. ETag should match the current
* entity state from the header response of the GET request or it should be *
Expand Down Expand Up @@ -1654,8 +1654,8 @@ class Group {
* @param {string} [parameters.externalId] Identifier of the external groups,
* this property contains the id of the group from the external identity
* provider, e.g. for Azure Active Directory
* aad://<tenant>.onmicrosoft.com/groups/<group object id>; otherwise the value
* is null.
* `aad://<tenant>.onmicrosoft.com/groups/<group object id>`; otherwise the
* value is null.
*
* @param {object} [options] Optional Parameters.
*
Expand Down Expand Up @@ -1707,8 +1707,8 @@ class Group {
* @param {string} [parameters.externalId] Identifier of the external groups,
* this property contains the id of the group from the external identity
* provider, e.g. for Azure Active Directory
* aad://<tenant>.onmicrosoft.com/groups/<group object id>; otherwise the value
* is null.
* `aad://<tenant>.onmicrosoft.com/groups/<group object id>`; otherwise the
* value is null.
*
* @param {object} [options] Optional Parameters.
*
Expand Down Expand Up @@ -1782,8 +1782,8 @@ class Group {
* @param {string} [parameters.externalId] Identifier of the external groups,
* this property contains the id of the group from the external identity
* provider, e.g. for Azure Active Directory
* aad://<tenant>.onmicrosoft.com/groups/<group object id>; otherwise the value
* is null.
* `aad://<tenant>.onmicrosoft.com/groups/<group object id>`; otherwise the
* value is null.
*
* @param {string} ifMatch ETag of the Entity. ETag should match the current
* entity state from the header response of the GET request or it should be *
Expand Down Expand Up @@ -1836,8 +1836,8 @@ class Group {
* @param {string} [parameters.externalId] Identifier of the external groups,
* this property contains the id of the group from the external identity
* provider, e.g. for Azure Active Directory
* aad://<tenant>.onmicrosoft.com/groups/<group object id>; otherwise the value
* is null.
* `aad://<tenant>.onmicrosoft.com/groups/<group object id>`; otherwise the
* value is null.
*
* @param {string} ifMatch ETag of the Entity. ETag should match the current
* entity state from the header response of the GET request or it should be *
Expand Down
16 changes: 8 additions & 8 deletions lib/services/apimanagement/lib/operations/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12159,8 +12159,8 @@ export interface Group {
* @param {string} [parameters.externalId] Identifier of the external groups,
* this property contains the id of the group from the external identity
* provider, e.g. for Azure Active Directory
* aad://<tenant>.onmicrosoft.com/groups/<group object id>; otherwise the value
* is null.
* `aad://<tenant>.onmicrosoft.com/groups/<group object id>`; otherwise the
* value is null.
*
* @param {object} [options] Optional Parameters.
*
Expand Down Expand Up @@ -12200,8 +12200,8 @@ export interface Group {
* @param {string} [parameters.externalId] Identifier of the external groups,
* this property contains the id of the group from the external identity
* provider, e.g. for Azure Active Directory
* aad://<tenant>.onmicrosoft.com/groups/<group object id>; otherwise the value
* is null.
* `aad://<tenant>.onmicrosoft.com/groups/<group object id>`; otherwise the
* value is null.
*
* @param {object} [options] Optional Parameters.
*
Expand Down Expand Up @@ -12260,8 +12260,8 @@ export interface Group {
* @param {string} [parameters.externalId] Identifier of the external groups,
* this property contains the id of the group from the external identity
* provider, e.g. for Azure Active Directory
* aad://<tenant>.onmicrosoft.com/groups/<group object id>; otherwise the value
* is null.
* `aad://<tenant>.onmicrosoft.com/groups/<group object id>`; otherwise the
* value is null.
*
* @param {string} ifMatch ETag of the Entity. ETag should match the current
* entity state from the header response of the GET request or it should be *
Expand Down Expand Up @@ -12302,8 +12302,8 @@ export interface Group {
* @param {string} [parameters.externalId] Identifier of the external groups,
* this property contains the id of the group from the external identity
* provider, e.g. for Azure Active Directory
* aad://<tenant>.onmicrosoft.com/groups/<group object id>; otherwise the value
* is null.
* `aad://<tenant>.onmicrosoft.com/groups/<group object id>`; otherwise the
* value is null.
*
* @param {string} ifMatch ETag of the Entity. ETag should match the current
* entity state from the header response of the GET request or it should be *
Expand Down
2 changes: 1 addition & 1 deletion lib/services/apimanagement/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"license": "MIT",
"main": "./lib/apiManagementClient.js",
"types": "./lib/apiManagementClient.d.ts",
"homepage": "https://github.com/azure/azure-sdk-for-node/lib/services/apimanagement",
"homepage": "https://github.com/azure/azure-sdk-for-node",
"repository": {
"type": "git",
"url": "https://github.com/azure/azure-sdk-for-node.git"
Expand Down