Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Missing docs for azure-sb package #5180

Closed
ramya-rao-a opened this issue Jul 17, 2020 · 7 comments
Closed

Missing docs for azure-sb package #5180

ramya-rao-a opened this issue Jul 17, 2020 · 7 comments
Assignees

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jul 17, 2020

azure-sb is the legacy package for Service Bus

Interestingly, it has code to support the Notification Hubs service as well, and therefore is not legacy on that front.

We plan to copy out the Notification Hubs code from this package to a separate package soon. But meanwhile, API reference docs for this package needs to show up under Notification Hubs for current users of azure-sb

If possible, reference docs for azure-sb should show up under "Service Bus" but under the "Legacy" moniker.

cc @scbedd

@scbedd
Copy link
Member

scbedd commented Jul 20, 2020

@ramya-rao-a thanks for the early heads up. I'm reading two requests here.

  1. Are you asking that I move azure-sb under Notification Hubs under the latest moniker right now?
  2. Add azure-sb under Service Bus under legacy moniker.

I'll get on 2) immediately, I'm not certain what to do with 1) until you respond though.

@ramya-rao-a
Copy link
Contributor Author

On second thoughts...

Let's go with 2) for now.
The splitting of Notification Hubs code from azure-sb to a new package should happen sooner than later. So, you can skip 1)

I'll log a separate request once the new package is out to get the ref docs generated for it under Notification Hubs

@scbedd
Copy link
Member

scbedd commented Jul 20, 2020

I have added azure-sb to legacy CI, and added it to the ToC in this commit as well. I'd very much like to include the legacy readme.

@ramya-rao-a Can you show me where azure-sb last published from so I can grab the readme and add it manually once?

@ramya-rao-a
Copy link
Contributor Author

@scbedd
Copy link
Member

scbedd commented Jul 23, 2020

Added azure-sb readme in this commit

@scbedd
Copy link
Member

scbedd commented Aug 2, 2020

Updates merged for this.

@scbedd scbedd closed this as completed Aug 2, 2020
@ramya-rao-a
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants