-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several documentation bugs #8861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlexanderSher
commented
Nov 21, 2019
- Fix Add CONTRIBUTING.md #7227: Add CONTRIBUTING.md
- Fix Add service level README #8473: Add service level README
- Fix Update docstrings #8651: Update docstrings
- Fix Azure#8473: Add service level README - Fix Azure#8651: Update docstrings
annelo-msft
reviewed
Nov 21, 2019
sdk/appconfiguration/Azure.Data.AppConfiguration/src/ConfigurationClient.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Nov 21, 2019
sdk/appconfiguration/Azure.Data.AppConfiguration/src/ConfigurationClientOptions.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Nov 21, 2019
annelo-msft
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments.
weshaggard
reviewed
Nov 21, 2019
weshaggard
reviewed
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.