Add Azure Function and remove Validation and Webhook activities #5158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relevant REST PRs after last SDK release: |
dsgouda
suggested changes
Jan 19, 2019
| /// (or Expression with resultType string), pattern: | ||
| /// ((\d+)\.)?(\d\d):(60|([0-5][0-9])):(60|([0-5][0-9])). | ||
| /// </summary> | ||
| [JsonProperty(PropertyName = "typeProperties.timeout")] |
There was a problem hiding this comment.
Please note that this is a breaking change
There was a problem hiding this comment.
@dsgouda This changes hasn't been released yet. We had similar comments on Specs PR and got sign off from them and ARM team. These are new activities we added last week, but didn't want them in this release, so we took them out
| @@ -10,17 +10,18 @@ | |||
| <AssemblyName>Microsoft.Azure.Management.DataFactory</AssemblyName> | |||
| <PackageTags>Microsoft Azure resource management;Data Factory;ADF;</PackageTags> | |||
| <PackageReleaseNotes> <![CDATA[ | |||
| - Added table name in dataset | |||
| - Added get Dataplane access API | |||
There was a problem hiding this comment.
Just to be sure, are you planning to bump the version in a different PR
There was a problem hiding this comment.
The version is already bumped by Meiyan in her PR to 3.0.0. That has not been released yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.