From 04723ffa48126742304ef812bca5d5c4c9a68772 Mon Sep 17 00:00:00 2001
From: Wei Hu <huwe@microsoft.com>
Date: Fri, 25 Oct 2024 16:45:04 +0800
Subject: [PATCH 1/9] Refine Azure SDK

---
 eng/Packages.Data.props                       |  2 +-
 .../Abstraction/HttpPipelineProvider.cs       |  6 +-
 .../Abstraction/HttpRequestProvider.cs        |  5 +-
 .../BasicTypeSpecClient.RestClient.cs         | 76 +++++++++----------
 .../Internal/ClientPipelineExtensions.cs      |  4 +-
 5 files changed, 45 insertions(+), 48 deletions(-)

diff --git a/eng/Packages.Data.props b/eng/Packages.Data.props
index f7bba64fc777..23315b6a3cef 100644
--- a/eng/Packages.Data.props
+++ b/eng/Packages.Data.props
@@ -243,7 +243,7 @@
   </ItemGroup>
 
   <ItemGroup Condition="'$(IsGeneratorLibrary)' == 'true'">
-    <PackageReference Update="Microsoft.Generator.CSharp.ClientModel" Version="1.0.0-alpha.20241022.3" />
+    <PackageReference Update="Microsoft.Generator.CSharp.ClientModel" Version="1.0.0-alpha.20241025.2" />
   </ItemGroup>
 
   <!--
diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
index 5a1c2e40553c..c74fec4824a4 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
@@ -6,6 +6,7 @@
 using Microsoft.Generator.CSharp.ClientModel.Providers;
 using Microsoft.Generator.CSharp.Expressions;
 using Microsoft.Generator.CSharp.Primitives;
+using Microsoft.Generator.CSharp.Providers;
 using static Microsoft.Generator.CSharp.Snippets.Snippet;
 
 namespace Azure.Generator.Providers.Abstraction
@@ -28,10 +29,7 @@ public HttpPipelineProvider(ValueExpression original) : base(typeof(HttpPipeline
         public override ValueExpression Create(ValueExpression options, ValueExpression perRetryPolicies)
             => Static(typeof(HttpPipelineBuilder)).Invoke(nameof(HttpPipelineBuilder.Build), [options, perRetryPolicies]);
 
-        public override HttpMessageApi CreateMessage()
-            => new HttpMessageProvider(Original.Invoke(nameof(HttpPipeline.CreateMessage)));
-
-        public override ValueExpression CreateMessage(HttpRequestOptionsApi requestOptions, ValueExpression responseClassifier)
+        public override ValueExpression CreateMessage(ParameterProvider requestOptions, ValueExpression responseClassifier)
             => Original.Invoke(nameof(HttpPipeline.CreateMessage), requestOptions, responseClassifier).As<HttpMessage>();
 
         public override ClientPipelineApi FromExpression(ValueExpression expression)
diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs
index 060ae8050a73..14004de04d24 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs
@@ -4,7 +4,6 @@
 using Azure.Core;
 using Microsoft.Generator.CSharp.ClientModel.Providers;
 using Microsoft.Generator.CSharp.Expressions;
-using Microsoft.Generator.CSharp.Snippets;
 using System.ClientModel.Primitives;
 using System.Collections.Generic;
 using static Microsoft.Generator.CSharp.Snippets.Snippet;
@@ -27,10 +26,10 @@ public override HttpRequestApi FromExpression(ValueExpression original)
             => new HttpRequestProvider(original);
 
         public override InvokeMethodExpression SetHeaders(IReadOnlyList<ValueExpression> arguments)
-            => Original.Property(nameof(PipelineRequest.Headers)).Invoke(nameof(RequestHeaders.Add), arguments);
+            => Original.Property(nameof(PipelineRequest.Headers)).Invoke(nameof(RequestHeaders.SetValue), arguments);
 
         public override AssignmentExpression SetMethod(string httpMethod)
-            => Original.Property(nameof(PipelineRequest.Method)).Assign(New.Instance(typeof(RequestMethod), [Literal(httpMethod)]));
+            => Original.Property(nameof(PipelineRequest.Method)).Assign(Static<RequestMethod>().Invoke(nameof(RequestMethod.Parse), [Literal(httpMethod)]));
 
         public override AssignmentExpression SetUri(ValueExpression value)
             => Original.Property("Uri").Assign(value);
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
index 8f3177cdbe6a..a54f4f16fd34 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
@@ -26,10 +26,10 @@ public partial class BasicTypeSpecClient
 
         internal HttpMessage CreateSayHiRequest(string headParameter, string queryParameter, string optionalQuery, RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("GET");
+            request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/hello", false);
@@ -39,17 +39,17 @@ internal HttpMessage CreateSayHiRequest(string headParameter, string queryParame
                 uri.AppendQuery("optionalQuery", optionalQuery, true);
             }
             request.Uri = uri;
-            request.Headers.Add("head-parameter", headParameter);
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("head-parameter", headParameter);
+            request.Headers.SetValue("Accept", "application/json");
             return message;
         }
 
         internal HttpMessage CreateHelloAgainRequest(string p2, string p1, RequestContent content, RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("GET");
+            request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/againHi/", false);
@@ -64,10 +64,10 @@ internal HttpMessage CreateHelloAgainRequest(string p2, string p1, RequestConten
 
         internal HttpMessage CreateNoContentTypeRequest(string p2, string p1, RequestContent content, RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("GET");
+            request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/noContentType/", false);
@@ -82,10 +82,10 @@ internal HttpMessage CreateNoContentTypeRequest(string p2, string p1, RequestCon
 
         internal HttpMessage CreateHelloDemo2Request(RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("GET");
+            request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/demoHi", false);
@@ -96,10 +96,10 @@ internal HttpMessage CreateHelloDemo2Request(RequestContext context)
 
         internal HttpMessage CreateCreateLiteralRequest(RequestContent content, RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("POST");
+            request.Method = RequestMethod.Parse("POST");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/literal", false);
@@ -112,10 +112,10 @@ internal HttpMessage CreateCreateLiteralRequest(RequestContent content, RequestC
 
         internal HttpMessage CreateHelloLiteralRequest(RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("GET");
+            request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/helloLiteral/", false);
@@ -129,10 +129,10 @@ internal HttpMessage CreateHelloLiteralRequest(RequestContext context)
 
         internal HttpMessage CreateTopActionRequest(DateTimeOffset action, RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("GET");
+            request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/top/", false);
@@ -144,10 +144,10 @@ internal HttpMessage CreateTopActionRequest(DateTimeOffset action, RequestContex
 
         internal HttpMessage CreateTopAction2Request(RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("GET");
+            request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/top2", false);
@@ -158,10 +158,10 @@ internal HttpMessage CreateTopAction2Request(RequestContext context)
 
         internal HttpMessage CreatePatchActionRequest(RequestContent content, RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("PATCH");
+            request.Method = RequestMethod.Parse("PATCH");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/patch", false);
@@ -174,10 +174,10 @@ internal HttpMessage CreatePatchActionRequest(RequestContent content, RequestCon
 
         internal HttpMessage CreateAnonymousBodyRequest(RequestContent content, RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("POST");
+            request.Method = RequestMethod.Parse("POST");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/anonymousBody", false);
@@ -190,10 +190,10 @@ internal HttpMessage CreateAnonymousBodyRequest(RequestContent content, RequestC
 
         internal HttpMessage CreateFriendlyModelRequest(RequestContent content, RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("POST");
+            request.Method = RequestMethod.Parse("POST");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/friendlyName", false);
@@ -206,10 +206,10 @@ internal HttpMessage CreateFriendlyModelRequest(RequestContent content, RequestC
 
         internal HttpMessage CreateAddTimeHeaderRequest(RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier204);
             message.ResponseClassifier = PipelineMessageClassifier204;
             Request request = message.Request;
-            request.Method = new RequestMethod("GET");
+            request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/", false);
@@ -220,10 +220,10 @@ internal HttpMessage CreateAddTimeHeaderRequest(RequestContext context)
 
         internal HttpMessage CreateProjectedNameModelRequest(RequestContent content, RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("POST");
+            request.Method = RequestMethod.Parse("POST");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/projectedName", false);
@@ -236,10 +236,10 @@ internal HttpMessage CreateProjectedNameModelRequest(RequestContent content, Req
 
         internal HttpMessage CreateReturnsAnonymousModelRequest(RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("POST");
+            request.Method = RequestMethod.Parse("POST");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/returnsAnonymousModel", false);
@@ -250,10 +250,10 @@ internal HttpMessage CreateReturnsAnonymousModelRequest(RequestContext context)
 
         internal HttpMessage CreateGetUnknownValueRequest(string accept, RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("GET");
+            request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/unknown-value", false);
@@ -264,10 +264,10 @@ internal HttpMessage CreateGetUnknownValueRequest(string accept, RequestContext
 
         internal HttpMessage CreateInternalProtocolRequest(RequestContent content, RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
-            request.Method = new RequestMethod("POST");
+            request.Method = RequestMethod.Parse("POST");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/internalProtocol", false);
@@ -280,10 +280,10 @@ internal HttpMessage CreateInternalProtocolRequest(RequestContent content, Reque
 
         internal HttpMessage CreateStillConvenientRequest(RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier204);
             message.ResponseClassifier = PipelineMessageClassifier204;
             Request request = message.Request;
-            request.Method = new RequestMethod("GET");
+            request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/stillConvenient", false);
@@ -293,10 +293,10 @@ internal HttpMessage CreateStillConvenientRequest(RequestContext context)
 
         internal HttpMessage CreateHeadAsBooleanRequest(string id, RequestContext context)
         {
-            HttpMessage message = Pipeline.CreateMessage();
+            HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier2xxAnd4xx);
             message.ResponseClassifier = PipelineMessageClassifier2xxAnd4xx;
             Request request = message.Request;
-            request.Method = new RequestMethod("HEAD");
+            request.Method = RequestMethod.Parse("HEAD");
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/headAsBoolean/", false);
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs
index 82e2f9dcaead..954f6efaa2dc 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs
@@ -16,7 +16,7 @@ internal static partial class ClientPipelineExtensions
     {
         public static async ValueTask<Response> ProcessMessageAsync(this HttpPipeline pipeline, HttpMessage message, RequestContext options)
         {
-            await pipeline.SendAsync(message, default).ConfigureAwait(false);
+            await pipeline.SendAsync(message, options.CancellationToken).ConfigureAwait(false);
 
             if (message.Response.IsError && (options?.ErrorOptions & ErrorOptions.NoThrow) != ErrorOptions.NoThrow)
             {
@@ -29,7 +29,7 @@ public static async ValueTask<Response> ProcessMessageAsync(this HttpPipeline pi
 
         public static Response ProcessMessage(this HttpPipeline pipeline, HttpMessage message, RequestContext options)
         {
-            pipeline.Send(message, default);
+            pipeline.Send(message, options.CancellationToken);
 
             if (message.Response.IsError && (options?.ErrorOptions & ErrorOptions.NoThrow) != ErrorOptions.NoThrow)
             {

From 18dbe9153121930fbc41042fe7e6b175befccad4 Mon Sep 17 00:00:00 2001
From: Wei Hu <huwe@microsoft.com>
Date: Fri, 25 Oct 2024 16:50:07 +0800
Subject: [PATCH 2/9] update

---
 .../Abstraction/HttpPipelineProvider.cs       | 10 ++--
 .../BasicTypeSpecClient.RestClient.cs         | 55 ++++++++++---------
 .../Internal/ClientPipelineExtensions.cs      | 20 +++----
 .../Models/RoundTripModel.Serialization.cs    |  8 ---
 .../Generated/Models/Thing.Serialization.cs   |  4 --
 5 files changed, 44 insertions(+), 53 deletions(-)

diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
index c74fec4824a4..70219f8b282d 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
@@ -38,12 +38,12 @@ public override ClientPipelineApi FromExpression(ValueExpression expression)
         public override ValueExpression PerRetryPolicy(params ValueExpression[] arguments)
             => Empty; // TODO: implement with default retry policy for Azure
 
-        public override InvokeMethodExpression Send(HttpMessageApi message)
-            => Original.Invoke(nameof(HttpPipeline.Send), [message, Default]);
+        public override ClientPipelineApi ToExpression() => this;
 
-        public override InvokeMethodExpression SendAsync(HttpMessageApi message)
-            => Original.Invoke(nameof(HttpPipeline.SendAsync), [message, Default], true);
+        public override InvokeMethodExpression Send(HttpMessageApi message, HttpRequestOptionsApi options)
+            => Original.Invoke(nameof(HttpPipeline.Send), [message, options.Property(nameof(RequestContext.CancellationToken))]);
 
-        public override ClientPipelineApi ToExpression() => this;
+        public override InvokeMethodExpression SendAsync(HttpMessageApi message, HttpRequestOptionsApi options)
+            => Original.Invoke(nameof(HttpPipeline.SendAsync), [message, options.Property(nameof(RequestContext.CancellationToken))], true);
     }
 }
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
index a54f4f16fd34..e56cbe5fab92 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
@@ -15,11 +15,14 @@ namespace BasicTypeSpec
     public partial class BasicTypeSpecClient
     {
         private static ResponseClassifier _pipelineMessageClassifier200;
+        private static ResponseClassifier _pipelineMessageClassifier201;
         private static ResponseClassifier _pipelineMessageClassifier204;
         private static Classifier2xxAnd4xx _pipelineMessageClassifier2xxAnd4xx;
 
         private static ResponseClassifier PipelineMessageClassifier200 => _pipelineMessageClassifier200 = new StatusCodeClassifier(stackalloc ushort[] { 200 });
 
+        private static ResponseClassifier PipelineMessageClassifier201 => _pipelineMessageClassifier201 = new StatusCodeClassifier(stackalloc ushort[] { 201 });
+
         private static ResponseClassifier PipelineMessageClassifier204 => _pipelineMessageClassifier204 = new StatusCodeClassifier(stackalloc ushort[] { 204 });
 
         private static Classifier2xxAnd4xx PipelineMessageClassifier2xxAnd4xx => _pipelineMessageClassifier2xxAnd4xx ??= new Classifier2xxAnd4xx();
@@ -55,9 +58,9 @@ internal HttpMessage CreateHelloAgainRequest(string p2, string p1, RequestConten
             uri.AppendPath("/againHi/", false);
             uri.AppendPath(p2, true);
             request.Uri = uri;
-            request.Headers.Add("p1", p1);
-            request.Headers.Add("Content-Type", "text/plain");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("p1", p1);
+            request.Headers.SetValue("Content-Type", "text/plain");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -73,9 +76,9 @@ internal HttpMessage CreateNoContentTypeRequest(string p2, string p1, RequestCon
             uri.AppendPath("/noContentType/", false);
             uri.AppendPath(p2, true);
             request.Uri = uri;
-            request.Headers.Add("p1", p1);
-            request.Headers.Add("Content-Type", "application/json");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("p1", p1);
+            request.Headers.SetValue("Content-Type", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -90,7 +93,7 @@ internal HttpMessage CreateHelloDemo2Request(RequestContext context)
             uri.Reset(_endpoint);
             uri.AppendPath("/demoHi", false);
             request.Uri = uri;
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             return message;
         }
 
@@ -104,8 +107,8 @@ internal HttpMessage CreateCreateLiteralRequest(RequestContent content, RequestC
             uri.Reset(_endpoint);
             uri.AppendPath("/literal", false);
             request.Uri = uri;
-            request.Headers.Add("Content-Type", "application/json");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Content-Type", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -122,8 +125,8 @@ internal HttpMessage CreateHelloLiteralRequest(RequestContext context)
             uri.AppendPath(123.ToString(), true);
             uri.AppendQuery("p3", TypeFormatters.ConvertToString(true, null), true);
             request.Uri = uri;
-            request.Headers.Add("p1", "test");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("p1", "test");
+            request.Headers.SetValue("Accept", "application/json");
             return message;
         }
 
@@ -138,7 +141,7 @@ internal HttpMessage CreateTopActionRequest(DateTimeOffset action, RequestContex
             uri.AppendPath("/top/", false);
             uri.AppendPath(action.ToString("O"), true);
             request.Uri = uri;
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             return message;
         }
 
@@ -152,7 +155,7 @@ internal HttpMessage CreateTopAction2Request(RequestContext context)
             uri.Reset(_endpoint);
             uri.AppendPath("/top2", false);
             request.Uri = uri;
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             return message;
         }
 
@@ -166,8 +169,8 @@ internal HttpMessage CreatePatchActionRequest(RequestContent content, RequestCon
             uri.Reset(_endpoint);
             uri.AppendPath("/patch", false);
             request.Uri = uri;
-            request.Headers.Add("Content-Type", "application/json");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Content-Type", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -182,8 +185,8 @@ internal HttpMessage CreateAnonymousBodyRequest(RequestContent content, RequestC
             uri.Reset(_endpoint);
             uri.AppendPath("/anonymousBody", false);
             request.Uri = uri;
-            request.Headers.Add("Content-Type", "application/json");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Content-Type", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -198,8 +201,8 @@ internal HttpMessage CreateFriendlyModelRequest(RequestContent content, RequestC
             uri.Reset(_endpoint);
             uri.AppendPath("/friendlyName", false);
             request.Uri = uri;
-            request.Headers.Add("Content-Type", "application/json");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Content-Type", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -214,7 +217,7 @@ internal HttpMessage CreateAddTimeHeaderRequest(RequestContext context)
             uri.Reset(_endpoint);
             uri.AppendPath("/", false);
             request.Uri = uri;
-            request.Headers.Add("Repeatability-First-Sent", TypeFormatters.ConvertToString(DateTimeOffset.Now, "R"));
+            request.Headers.SetValue("Repeatability-First-Sent", TypeFormatters.ConvertToString(DateTimeOffset.Now, "R"));
             return message;
         }
 
@@ -228,8 +231,8 @@ internal HttpMessage CreateProjectedNameModelRequest(RequestContent content, Req
             uri.Reset(_endpoint);
             uri.AppendPath("/projectedName", false);
             request.Uri = uri;
-            request.Headers.Add("Content-Type", "application/json");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Content-Type", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -244,7 +247,7 @@ internal HttpMessage CreateReturnsAnonymousModelRequest(RequestContext context)
             uri.Reset(_endpoint);
             uri.AppendPath("/returnsAnonymousModel", false);
             request.Uri = uri;
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             return message;
         }
 
@@ -258,7 +261,7 @@ internal HttpMessage CreateGetUnknownValueRequest(string accept, RequestContext
             uri.Reset(_endpoint);
             uri.AppendPath("/unknown-value", false);
             request.Uri = uri;
-            request.Headers.Add("Accept", accept);
+            request.Headers.SetValue("Accept", accept);
             return message;
         }
 
@@ -272,8 +275,8 @@ internal HttpMessage CreateInternalProtocolRequest(RequestContent content, Reque
             uri.Reset(_endpoint);
             uri.AppendPath("/internalProtocol", false);
             request.Uri = uri;
-            request.Headers.Add("Content-Type", "application/json");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Content-Type", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs
index 954f6efaa2dc..6a2867133985 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs
@@ -14,11 +14,11 @@ namespace BasicTypeSpec
 {
     internal static partial class ClientPipelineExtensions
     {
-        public static async ValueTask<Response> ProcessMessageAsync(this HttpPipeline pipeline, HttpMessage message, RequestContext options)
+        public static async ValueTask<Response> ProcessMessageAsync(this HttpPipeline pipeline, HttpMessage message, RequestContext context)
         {
-            await pipeline.SendAsync(message, options.CancellationToken).ConfigureAwait(false);
+            await pipeline.SendAsync(message, context.CancellationToken).ConfigureAwait(false);
 
-            if (message.Response.IsError && (options?.ErrorOptions & ErrorOptions.NoThrow) != ErrorOptions.NoThrow)
+            if (message.Response.IsError && (context?.ErrorOptions & ErrorOptions.NoThrow) != ErrorOptions.NoThrow)
             {
                 throw new RequestFailedException(message.Response);
             }
@@ -27,11 +27,11 @@ public static async ValueTask<Response> ProcessMessageAsync(this HttpPipeline pi
             return response;
         }
 
-        public static Response ProcessMessage(this HttpPipeline pipeline, HttpMessage message, RequestContext options)
+        public static Response ProcessMessage(this HttpPipeline pipeline, HttpMessage message, RequestContext context)
         {
-            pipeline.Send(message, options.CancellationToken);
+            pipeline.Send(message, context.CancellationToken);
 
-            if (message.Response.IsError && (options?.ErrorOptions & ErrorOptions.NoThrow) != ErrorOptions.NoThrow)
+            if (message.Response.IsError && (context?.ErrorOptions & ErrorOptions.NoThrow) != ErrorOptions.NoThrow)
             {
                 throw new RequestFailedException(message.Response);
             }
@@ -40,9 +40,9 @@ public static Response ProcessMessage(this HttpPipeline pipeline, HttpMessage me
             return response;
         }
 
-        public static async ValueTask<Response<bool>> ProcessHeadAsBoolMessageAsync(this HttpPipeline pipeline, HttpMessage message, RequestContext options)
+        public static async ValueTask<Response<bool>> ProcessHeadAsBoolMessageAsync(this HttpPipeline pipeline, HttpMessage message, RequestContext context)
         {
-            Response response = await pipeline.ProcessMessageAsync(message, options).ConfigureAwait(false);
+            Response response = await pipeline.ProcessMessageAsync(message, context).ConfigureAwait(false);
             switch (response.Status)
             {
                 case >= 200 and < 300:
@@ -54,9 +54,9 @@ public static async ValueTask<Response<bool>> ProcessHeadAsBoolMessageAsync(this
             }
         }
 
-        public static Response<bool> ProcessHeadAsBoolMessage(this HttpPipeline pipeline, HttpMessage message, RequestContext options)
+        public static Response<bool> ProcessHeadAsBoolMessage(this HttpPipeline pipeline, HttpMessage message, RequestContext context)
         {
-            Response response = pipeline.ProcessMessage(message, options);
+            Response response = pipeline.ProcessMessage(message, context);
             switch (response.Status)
             {
                 case >= 200 and < 300:
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/RoundTripModel.Serialization.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/RoundTripModel.Serialization.cs
index 62467f32c0fe..6eb941b8f900 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/RoundTripModel.Serialization.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/RoundTripModel.Serialization.cs
@@ -352,7 +352,6 @@ internal static RoundTripModel DeserializeRoundTripModel(JsonElement element, Mo
                 {
                     if (prop.Value.ValueKind == JsonValueKind.Null)
                     {
-                        intExtensibleEnum = null;
                         continue;
                     }
                     intExtensibleEnum = new IntExtensibleEnum(prop.Value.GetInt32());
@@ -376,7 +375,6 @@ internal static RoundTripModel DeserializeRoundTripModel(JsonElement element, Mo
                 {
                     if (prop.Value.ValueKind == JsonValueKind.Null)
                     {
-                        floatExtensibleEnum = null;
                         continue;
                     }
                     floatExtensibleEnum = new FloatExtensibleEnum(prop.Value.GetSingle());
@@ -386,7 +384,6 @@ internal static RoundTripModel DeserializeRoundTripModel(JsonElement element, Mo
                 {
                     if (prop.Value.ValueKind == JsonValueKind.Null)
                     {
-                        floatExtensibleEnumWithIntValue = null;
                         continue;
                     }
                     floatExtensibleEnumWithIntValue = new FloatExtensibleEnumWithIntValue(prop.Value.GetSingle());
@@ -410,7 +407,6 @@ internal static RoundTripModel DeserializeRoundTripModel(JsonElement element, Mo
                 {
                     if (prop.Value.ValueKind == JsonValueKind.Null)
                     {
-                        floatFixedEnum = null;
                         continue;
                     }
                     floatFixedEnum = prop.Value.GetSingle().ToFloatFixedEnum();
@@ -420,7 +416,6 @@ internal static RoundTripModel DeserializeRoundTripModel(JsonElement element, Mo
                 {
                     if (prop.Value.ValueKind == JsonValueKind.Null)
                     {
-                        floatFixedEnumWithIntValue = null;
                         continue;
                     }
                     floatFixedEnumWithIntValue = prop.Value.GetInt32().ToFloatFixedEnumWithIntValue();
@@ -444,7 +439,6 @@ internal static RoundTripModel DeserializeRoundTripModel(JsonElement element, Mo
                 {
                     if (prop.Value.ValueKind == JsonValueKind.Null)
                     {
-                        intFixedEnum = null;
                         continue;
                     }
                     intFixedEnum = prop.Value.GetInt32().ToIntFixedEnum();
@@ -468,7 +462,6 @@ internal static RoundTripModel DeserializeRoundTripModel(JsonElement element, Mo
                 {
                     if (prop.Value.ValueKind == JsonValueKind.Null)
                     {
-                        stringFixedEnum = null;
                         continue;
                     }
                     stringFixedEnum = prop.Value.GetString().ToStringFixedEnum();
@@ -483,7 +476,6 @@ internal static RoundTripModel DeserializeRoundTripModel(JsonElement element, Mo
                 {
                     if (prop.Value.ValueKind == JsonValueKind.Null)
                     {
-                        optionalUnknown = null;
                         continue;
                     }
                     optionalUnknown = BinaryData.FromString(prop.Value.GetRawText());
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/Thing.Serialization.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/Thing.Serialization.cs
index c473fa19a5fa..4dd6a48493ed 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/Thing.Serialization.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/Thing.Serialization.cs
@@ -198,7 +198,6 @@ internal static Thing DeserializeThing(JsonElement element, ModelReaderWriterOpt
                 {
                     if (prop.Value.ValueKind == JsonValueKind.Null)
                     {
-                        optionalLiteralString = null;
                         continue;
                     }
                     optionalLiteralString = new ThingOptionalLiteralString(prop.Value.GetString());
@@ -208,7 +207,6 @@ internal static Thing DeserializeThing(JsonElement element, ModelReaderWriterOpt
                 {
                     if (prop.Value.ValueKind == JsonValueKind.Null)
                     {
-                        optionalLiteralInt = null;
                         continue;
                     }
                     optionalLiteralInt = new ThingOptionalLiteralInt(prop.Value.GetInt32());
@@ -218,7 +216,6 @@ internal static Thing DeserializeThing(JsonElement element, ModelReaderWriterOpt
                 {
                     if (prop.Value.ValueKind == JsonValueKind.Null)
                     {
-                        optionalLiteralFloat = null;
                         continue;
                     }
                     optionalLiteralFloat = new ThingOptionalLiteralFloat(prop.Value.GetSingle());
@@ -228,7 +225,6 @@ internal static Thing DeserializeThing(JsonElement element, ModelReaderWriterOpt
                 {
                     if (prop.Value.ValueKind == JsonValueKind.Null)
                     {
-                        optionalLiteralBool = null;
                         continue;
                     }
                     optionalLiteralBool = prop.Value.GetBoolean();

From 5f623e2e4352ca6c8ce37d700488d8038ebee86a Mon Sep 17 00:00:00 2001
From: Wei Hu <huwe@microsoft.com>
Date: Mon, 28 Oct 2024 11:41:40 +0800
Subject: [PATCH 3/9] skip message assignment

---
 eng/Packages.Data.props                        |  2 +-
 .../Abstraction/HttpMessageProvider.cs         |  6 +++---
 .../Abstraction/HttpPipelineProvider.cs        |  2 +-
 .../BasicTypeSpecClient.RestClient.cs          | 18 ------------------
 4 files changed, 5 insertions(+), 23 deletions(-)

diff --git a/eng/Packages.Data.props b/eng/Packages.Data.props
index 23315b6a3cef..ad41379e4435 100644
--- a/eng/Packages.Data.props
+++ b/eng/Packages.Data.props
@@ -243,7 +243,7 @@
   </ItemGroup>
 
   <ItemGroup Condition="'$(IsGeneratorLibrary)' == 'true'">
-    <PackageReference Update="Microsoft.Generator.CSharp.ClientModel" Version="1.0.0-alpha.20241025.2" />
+    <PackageReference Update="Microsoft.Generator.CSharp.ClientModel" Version="1.0.0-alpha.20241027.2" />
   </ItemGroup>
 
   <!--
diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpMessageProvider.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpMessageProvider.cs
index 43391c5ca039..f82b8f724434 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpMessageProvider.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpMessageProvider.cs
@@ -39,9 +39,9 @@ public override HttpRequestApi Request()
         public override HttpResponseApi Response()
             => new AzureResponseProvider(Original.Property(nameof(HttpMessage.Response)));
 
-        public override ValueExpression ResponseClassifier()
-            => Original.Property(nameof(HttpMessage.ResponseClassifier));
-
         public override HttpMessageApi ToExpression() => this;
+
+        public override MethodBodyStatement Assign(StatusCodeClassifierApi statusCodeClassifier)
+            => MethodBodyStatement.Empty;
     }
 }
diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
index 70219f8b282d..8bb6e354f391 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
@@ -29,7 +29,7 @@ public HttpPipelineProvider(ValueExpression original) : base(typeof(HttpPipeline
         public override ValueExpression Create(ValueExpression options, ValueExpression perRetryPolicies)
             => Static(typeof(HttpPipelineBuilder)).Invoke(nameof(HttpPipelineBuilder.Build), [options, perRetryPolicies]);
 
-        public override ValueExpression CreateMessage(ParameterProvider requestOptions, ValueExpression responseClassifier)
+        public override ValueExpression CreateMessage(HttpRequestOptionsApi requestOptions, ValueExpression responseClassifier)
             => Original.Invoke(nameof(HttpPipeline.CreateMessage), requestOptions, responseClassifier).As<HttpMessage>();
 
         public override ClientPipelineApi FromExpression(ValueExpression expression)
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
index e56cbe5fab92..df208acf2f09 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
@@ -30,7 +30,6 @@ public partial class BasicTypeSpecClient
         internal HttpMessage CreateSayHiRequest(string headParameter, string queryParameter, string optionalQuery, RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -50,7 +49,6 @@ internal HttpMessage CreateSayHiRequest(string headParameter, string queryParame
         internal HttpMessage CreateHelloAgainRequest(string p2, string p1, RequestContent content, RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -68,7 +66,6 @@ internal HttpMessage CreateHelloAgainRequest(string p2, string p1, RequestConten
         internal HttpMessage CreateNoContentTypeRequest(string p2, string p1, RequestContent content, RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -86,7 +83,6 @@ internal HttpMessage CreateNoContentTypeRequest(string p2, string p1, RequestCon
         internal HttpMessage CreateHelloDemo2Request(RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -100,7 +96,6 @@ internal HttpMessage CreateHelloDemo2Request(RequestContext context)
         internal HttpMessage CreateCreateLiteralRequest(RequestContent content, RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("POST");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -116,7 +111,6 @@ internal HttpMessage CreateCreateLiteralRequest(RequestContent content, RequestC
         internal HttpMessage CreateHelloLiteralRequest(RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -133,7 +127,6 @@ internal HttpMessage CreateHelloLiteralRequest(RequestContext context)
         internal HttpMessage CreateTopActionRequest(DateTimeOffset action, RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -148,7 +141,6 @@ internal HttpMessage CreateTopActionRequest(DateTimeOffset action, RequestContex
         internal HttpMessage CreateTopAction2Request(RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -162,7 +154,6 @@ internal HttpMessage CreateTopAction2Request(RequestContext context)
         internal HttpMessage CreatePatchActionRequest(RequestContent content, RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("PATCH");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -178,7 +169,6 @@ internal HttpMessage CreatePatchActionRequest(RequestContent content, RequestCon
         internal HttpMessage CreateAnonymousBodyRequest(RequestContent content, RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("POST");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -194,7 +184,6 @@ internal HttpMessage CreateAnonymousBodyRequest(RequestContent content, RequestC
         internal HttpMessage CreateFriendlyModelRequest(RequestContent content, RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("POST");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -210,7 +199,6 @@ internal HttpMessage CreateFriendlyModelRequest(RequestContent content, RequestC
         internal HttpMessage CreateAddTimeHeaderRequest(RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier204);
-            message.ResponseClassifier = PipelineMessageClassifier204;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -224,7 +212,6 @@ internal HttpMessage CreateAddTimeHeaderRequest(RequestContext context)
         internal HttpMessage CreateProjectedNameModelRequest(RequestContent content, RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("POST");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -240,7 +227,6 @@ internal HttpMessage CreateProjectedNameModelRequest(RequestContent content, Req
         internal HttpMessage CreateReturnsAnonymousModelRequest(RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("POST");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -254,7 +240,6 @@ internal HttpMessage CreateReturnsAnonymousModelRequest(RequestContext context)
         internal HttpMessage CreateGetUnknownValueRequest(string accept, RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -268,7 +253,6 @@ internal HttpMessage CreateGetUnknownValueRequest(string accept, RequestContext
         internal HttpMessage CreateInternalProtocolRequest(RequestContent content, RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
-            message.ResponseClassifier = PipelineMessageClassifier200;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("POST");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -284,7 +268,6 @@ internal HttpMessage CreateInternalProtocolRequest(RequestContent content, Reque
         internal HttpMessage CreateStillConvenientRequest(RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier204);
-            message.ResponseClassifier = PipelineMessageClassifier204;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("GET");
             ClientUriBuilder uri = new ClientUriBuilder();
@@ -297,7 +280,6 @@ internal HttpMessage CreateStillConvenientRequest(RequestContext context)
         internal HttpMessage CreateHeadAsBooleanRequest(string id, RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier2xxAnd4xx);
-            message.ResponseClassifier = PipelineMessageClassifier2xxAnd4xx;
             Request request = message.Request;
             request.Method = RequestMethod.Parse("HEAD");
             ClientUriBuilder uri = new ClientUriBuilder();

From f471d30699a898a10790ee56787b4e18fd29de28 Mon Sep 17 00:00:00 2001
From: Wei Hu <huwe@microsoft.com>
Date: Tue, 29 Oct 2024 11:54:15 +0800
Subject: [PATCH 4/9] Parse http method during generation instread of run-time

---
 eng/Packages.Data.props                       |  2 +-
 .../Abstraction/HttpMessageProvider.cs        |  8 +-
 .../Abstraction/HttpPipelineProvider.cs       | 10 +--
 .../Abstraction/HttpRequestProvider.cs        | 78 +++++++++++++++++--
 .../BasicTypeSpecClient.RestClient.cs         | 36 ++++-----
 5 files changed, 100 insertions(+), 34 deletions(-)

diff --git a/eng/Packages.Data.props b/eng/Packages.Data.props
index ad41379e4435..80878a84f59c 100644
--- a/eng/Packages.Data.props
+++ b/eng/Packages.Data.props
@@ -243,7 +243,7 @@
   </ItemGroup>
 
   <ItemGroup Condition="'$(IsGeneratorLibrary)' == 'true'">
-    <PackageReference Update="Microsoft.Generator.CSharp.ClientModel" Version="1.0.0-alpha.20241027.2" />
+    <PackageReference Update="Microsoft.Generator.CSharp.ClientModel" Version="1.0.0-alpha.20241028.4" />
   </ItemGroup>
 
   <!--
diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpMessageProvider.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpMessageProvider.cs
index f82b8f724434..95ffb0b02cd2 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpMessageProvider.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpMessageProvider.cs
@@ -21,9 +21,6 @@ public HttpMessageProvider(ValueExpression original) : base(typeof(HttpMessage),
 
         public override CSharpType HttpMessageType => typeof(HttpMessage);
 
-        public override MethodBodyStatement Apply(ValueExpression options)
-            => MethodBodyStatement.Empty;
-
         public override ValueExpression BufferResponse()
             => Original.Property(nameof(HttpMessage.BufferResponse));
 
@@ -41,7 +38,10 @@ public override HttpResponseApi Response()
 
         public override HttpMessageApi ToExpression() => this;
 
-        public override MethodBodyStatement Assign(StatusCodeClassifierApi statusCodeClassifier)
+        public override MethodBodyStatement ApplyResponseClassifier(StatusCodeClassifierApi statusCodeClassifier)
+            => MethodBodyStatement.Empty;
+
+        public override MethodBodyStatement ApplyRequestOptions(HttpRequestOptionsApi options)
             => MethodBodyStatement.Empty;
     }
 }
diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
index 8bb6e354f391..3fc685ea0da4 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
@@ -6,7 +6,7 @@
 using Microsoft.Generator.CSharp.ClientModel.Providers;
 using Microsoft.Generator.CSharp.Expressions;
 using Microsoft.Generator.CSharp.Primitives;
-using Microsoft.Generator.CSharp.Providers;
+using Microsoft.Generator.CSharp.Statements;
 using static Microsoft.Generator.CSharp.Snippets.Snippet;
 
 namespace Azure.Generator.Providers.Abstraction
@@ -40,10 +40,10 @@ public override ValueExpression PerRetryPolicy(params ValueExpression[] argument
 
         public override ClientPipelineApi ToExpression() => this;
 
-        public override InvokeMethodExpression Send(HttpMessageApi message, HttpRequestOptionsApi options)
-            => Original.Invoke(nameof(HttpPipeline.Send), [message, options.Property(nameof(RequestContext.CancellationToken))]);
+        public override MethodBodyStatement Send(HttpMessageApi message, HttpRequestOptionsApi options)
+            => Original.Invoke(nameof(HttpPipeline.Send), [message, options.Property(nameof(RequestContext.CancellationToken))]).Terminate();
 
-        public override InvokeMethodExpression SendAsync(HttpMessageApi message, HttpRequestOptionsApi options)
-            => Original.Invoke(nameof(HttpPipeline.SendAsync), [message, options.Property(nameof(RequestContext.CancellationToken))], true);
+        public override MethodBodyStatement SendAsync(HttpMessageApi message, HttpRequestOptionsApi options)
+            => Original.Invoke(nameof(HttpPipeline.SendAsync), [message, options.Property(nameof(RequestContext.CancellationToken))], true).Terminate();
     }
 }
diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs
index 14004de04d24..37f0f6278f65 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs
@@ -4,6 +4,8 @@
 using Azure.Core;
 using Microsoft.Generator.CSharp.ClientModel.Providers;
 using Microsoft.Generator.CSharp.Expressions;
+using Microsoft.Generator.CSharp.Statements;
+using System;
 using System.ClientModel.Primitives;
 using System.Collections.Generic;
 using static Microsoft.Generator.CSharp.Snippets.Snippet;
@@ -25,15 +27,79 @@ public override ValueExpression Content()
         public override HttpRequestApi FromExpression(ValueExpression original)
             => new HttpRequestProvider(original);
 
-        public override InvokeMethodExpression SetHeaders(IReadOnlyList<ValueExpression> arguments)
-            => Original.Property(nameof(PipelineRequest.Headers)).Invoke(nameof(RequestHeaders.SetValue), arguments);
+        public override MethodBodyStatement SetHeaders(IReadOnlyList<ValueExpression> arguments)
+            => Original.Property(nameof(PipelineRequest.Headers)).Invoke(nameof(RequestHeaders.SetValue), arguments).Terminate();
 
-        public override AssignmentExpression SetMethod(string httpMethod)
-            => Original.Property(nameof(PipelineRequest.Method)).Assign(Static<RequestMethod>().Invoke(nameof(RequestMethod.Parse), [Literal(httpMethod)]));
+        public override MethodBodyStatement SetMethod(string httpMethod)
+            => Original.Property(nameof(PipelineRequest.Method)).Assign(CreateRequestMethod(httpMethod)).Terminate();
 
-        public override AssignmentExpression SetUri(ValueExpression value)
-            => Original.Property("Uri").Assign(value);
+        public override MethodBodyStatement SetUri(ValueExpression value)
+            => Original.Property("Uri").Assign(value).Terminate();
 
         public override HttpRequestApi ToExpression() => this;
+
+        private ValueExpression CreateRequestMethod(string httpMethod)
+        {
+            var httpMethodString = ParseHttpMethodString(httpMethod);
+            return httpMethodString is null
+                ? New.Instance(typeof(RequestMethod), [Literal(httpMethod)])
+                : Static<RequestMethod>().Property(httpMethodString);
+        }
+
+        private string? ParseHttpMethodString(string method)
+        {
+            if (method == null)
+            {
+                throw new ArgumentNullException(nameof(method));
+            }
+            if (method.Length == 3)
+            {
+                if (string.Equals(method, "GET", StringComparison.OrdinalIgnoreCase))
+                {
+                    return "Get";
+                }
+
+                if (string.Equals(method, "PUT", StringComparison.OrdinalIgnoreCase))
+                {
+                    return "Put";
+                }
+            }
+            else if (method.Length == 4)
+            {
+                if (string.Equals(method, "POST", StringComparison.OrdinalIgnoreCase))
+                {
+                    return "Post";
+                }
+
+                if (string.Equals(method, "HEAD", StringComparison.OrdinalIgnoreCase))
+                {
+                    return "Head";
+                }
+            }
+            else
+            {
+                if (string.Equals(method, "PATCH", StringComparison.OrdinalIgnoreCase))
+                {
+                    return "Patch";
+                }
+
+                if (string.Equals(method, "DELETE", StringComparison.OrdinalIgnoreCase))
+                {
+                    return "Delete";
+                }
+
+                if (string.Equals(method, "OPTIONS", StringComparison.OrdinalIgnoreCase))
+                {
+                    return "Options";
+                }
+
+                if (string.Equals(method, "TRACE", StringComparison.OrdinalIgnoreCase))
+                {
+                    return "Trace";
+                }
+            }
+
+            return null;
+        }
     }
 }
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
index df208acf2f09..eb6682ff07e3 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
@@ -31,7 +31,7 @@ internal HttpMessage CreateSayHiRequest(string headParameter, string queryParame
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("GET");
+            request.Method = RequestMethod.Get;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/hello", false);
@@ -50,7 +50,7 @@ internal HttpMessage CreateHelloAgainRequest(string p2, string p1, RequestConten
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("GET");
+            request.Method = RequestMethod.Get;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/againHi/", false);
@@ -67,7 +67,7 @@ internal HttpMessage CreateNoContentTypeRequest(string p2, string p1, RequestCon
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("GET");
+            request.Method = RequestMethod.Get;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/noContentType/", false);
@@ -84,7 +84,7 @@ internal HttpMessage CreateHelloDemo2Request(RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("GET");
+            request.Method = RequestMethod.Get;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/demoHi", false);
@@ -97,7 +97,7 @@ internal HttpMessage CreateCreateLiteralRequest(RequestContent content, RequestC
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("POST");
+            request.Method = RequestMethod.Post;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/literal", false);
@@ -112,7 +112,7 @@ internal HttpMessage CreateHelloLiteralRequest(RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("GET");
+            request.Method = RequestMethod.Get;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/helloLiteral/", false);
@@ -128,7 +128,7 @@ internal HttpMessage CreateTopActionRequest(DateTimeOffset action, RequestContex
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("GET");
+            request.Method = RequestMethod.Get;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/top/", false);
@@ -142,7 +142,7 @@ internal HttpMessage CreateTopAction2Request(RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("GET");
+            request.Method = RequestMethod.Get;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/top2", false);
@@ -155,7 +155,7 @@ internal HttpMessage CreatePatchActionRequest(RequestContent content, RequestCon
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("PATCH");
+            request.Method = RequestMethod.Patch;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/patch", false);
@@ -170,7 +170,7 @@ internal HttpMessage CreateAnonymousBodyRequest(RequestContent content, RequestC
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("POST");
+            request.Method = RequestMethod.Post;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/anonymousBody", false);
@@ -185,7 +185,7 @@ internal HttpMessage CreateFriendlyModelRequest(RequestContent content, RequestC
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("POST");
+            request.Method = RequestMethod.Post;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/friendlyName", false);
@@ -200,7 +200,7 @@ internal HttpMessage CreateAddTimeHeaderRequest(RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier204);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("GET");
+            request.Method = RequestMethod.Get;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/", false);
@@ -213,7 +213,7 @@ internal HttpMessage CreateProjectedNameModelRequest(RequestContent content, Req
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("POST");
+            request.Method = RequestMethod.Post;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/projectedName", false);
@@ -228,7 +228,7 @@ internal HttpMessage CreateReturnsAnonymousModelRequest(RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("POST");
+            request.Method = RequestMethod.Post;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/returnsAnonymousModel", false);
@@ -241,7 +241,7 @@ internal HttpMessage CreateGetUnknownValueRequest(string accept, RequestContext
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("GET");
+            request.Method = RequestMethod.Get;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/unknown-value", false);
@@ -254,7 +254,7 @@ internal HttpMessage CreateInternalProtocolRequest(RequestContent content, Reque
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier200);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("POST");
+            request.Method = RequestMethod.Post;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/internalProtocol", false);
@@ -269,7 +269,7 @@ internal HttpMessage CreateStillConvenientRequest(RequestContext context)
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier204);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("GET");
+            request.Method = RequestMethod.Get;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/stillConvenient", false);
@@ -281,7 +281,7 @@ internal HttpMessage CreateHeadAsBooleanRequest(string id, RequestContext contex
         {
             HttpMessage message = Pipeline.CreateMessage(context, PipelineMessageClassifier2xxAnd4xx);
             Request request = message.Request;
-            request.Method = RequestMethod.Parse("HEAD");
+            request.Method = RequestMethod.Head;
             ClientUriBuilder uri = new ClientUriBuilder();
             uri.Reset(_endpoint);
             uri.AppendPath("/headAsBoolean/", false);

From 27bc8c23fbcfffc46f62594cf34213cf23152bc4 Mon Sep 17 00:00:00 2001
From: Wei Hu <huwe@microsoft.com>
Date: Thu, 31 Oct 2024 14:59:04 +0800
Subject: [PATCH 5/9] update MGC

---
 eng/Packages.Data.props                              |  2 +-
 .../src/Generated/BasicTypeSpecModelFactory.cs       | 12 ++++++------
 .../src/Generated/Models/Friend.Serialization.cs     |  4 ++++
 ...elWithRequiredNullableProperties.Serialization.cs |  4 ++++
 .../Generated/Models/ProjectedModel.Serialization.cs |  4 ++++
 .../ReturnsAnonymousModelResponse.Serialization.cs   |  4 ++++
 .../Generated/Models/RoundTripModel.Serialization.cs |  4 ++++
 .../src/Generated/Models/Thing.Serialization.cs      |  4 ++++
 8 files changed, 31 insertions(+), 7 deletions(-)

diff --git a/eng/Packages.Data.props b/eng/Packages.Data.props
index 80878a84f59c..eaf629dc46eb 100644
--- a/eng/Packages.Data.props
+++ b/eng/Packages.Data.props
@@ -243,7 +243,7 @@
   </ItemGroup>
 
   <ItemGroup Condition="'$(IsGeneratorLibrary)' == 'true'">
-    <PackageReference Update="Microsoft.Generator.CSharp.ClientModel" Version="1.0.0-alpha.20241028.4" />
+    <PackageReference Update="Microsoft.Generator.CSharp.ClientModel" Version="1.0.0-alpha.20241030.4" />
   </ItemGroup>
 
   <!--
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecModelFactory.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecModelFactory.cs
index b52d06da39c9..c14a249fd60e 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecModelFactory.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecModelFactory.cs
@@ -49,7 +49,7 @@ public static Thing Thing(string name = default, BinaryData requiredUnion = defa
                 requiredBadDescription,
                 optionalNullableList?.ToList(),
                 requiredNullableList?.ToList(),
-                null);
+                additionalBinaryDataProperties: null);
         }
 
         /// <summary> this is a roundtrip model. </summary>
@@ -116,7 +116,7 @@ public static RoundTripModel RoundTripModel(string requiredString = default, int
                 readOnlyOptionalRecordUnknown,
                 modelWithRequiredNullable,
                 requiredBytes,
-                null);
+                additionalBinaryDataProperties: null);
         }
 
         /// <summary> A model with a few required nullable properties. </summary>
@@ -127,7 +127,7 @@ public static RoundTripModel RoundTripModel(string requiredString = default, int
         public static ModelWithRequiredNullableProperties ModelWithRequiredNullableProperties(int? requiredNullablePrimitive = default, StringExtensibleEnum? requiredExtensibleEnum = default, StringFixedEnum? requiredFixedEnum = default)
         {
 
-            return new ModelWithRequiredNullableProperties(requiredNullablePrimitive, requiredExtensibleEnum, requiredFixedEnum, null);
+            return new ModelWithRequiredNullableProperties(requiredNullablePrimitive, requiredExtensibleEnum, requiredFixedEnum, additionalBinaryDataProperties: null);
         }
 
         /// <summary> this is not a friendly model but with a friendly name. </summary>
@@ -136,7 +136,7 @@ public static ModelWithRequiredNullableProperties ModelWithRequiredNullablePrope
         public static Friend Friend(string name = default)
         {
 
-            return new Friend(name, null);
+            return new Friend(name, additionalBinaryDataProperties: null);
         }
 
         /// <summary> this is a model with a projected name. </summary>
@@ -145,7 +145,7 @@ public static Friend Friend(string name = default)
         public static ProjectedModel ProjectedModel(string name = default)
         {
 
-            return new ProjectedModel(name, null);
+            return new ProjectedModel(name, additionalBinaryDataProperties: null);
         }
 
         /// <summary> The ReturnsAnonymousModelResponse. </summary>
@@ -153,7 +153,7 @@ public static ProjectedModel ProjectedModel(string name = default)
         public static ReturnsAnonymousModelResponse ReturnsAnonymousModelResponse()
         {
 
-            return new ReturnsAnonymousModelResponse(null);
+            return new ReturnsAnonymousModelResponse(additionalBinaryDataProperties: null);
         }
     }
 }
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/Friend.Serialization.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/Friend.Serialization.cs
index f92833ee37f3..4f53647f4410 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/Friend.Serialization.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/Friend.Serialization.cs
@@ -134,6 +134,10 @@ protected virtual Friend PersistableModelCreateCore(BinaryData data, ModelReader
         /// <param name="friend"> The <see cref="Friend"/> to serialize into <see cref="RequestContent"/>. </param>
         public static implicit operator RequestContent(Friend friend)
         {
+            if (friend == null)
+            {
+                return null;
+            }
             Utf8JsonBinaryContent content = new Utf8JsonBinaryContent();
             content.JsonWriter.WriteObjectValue(friend, ModelSerializationExtensions.WireOptions);
             return content;
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ModelWithRequiredNullableProperties.Serialization.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ModelWithRequiredNullableProperties.Serialization.cs
index baa17dbaa1cb..b750c8647796 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ModelWithRequiredNullableProperties.Serialization.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ModelWithRequiredNullableProperties.Serialization.cs
@@ -186,6 +186,10 @@ protected virtual ModelWithRequiredNullableProperties PersistableModelCreateCore
         /// <param name="modelWithRequiredNullableProperties"> The <see cref="ModelWithRequiredNullableProperties"/> to serialize into <see cref="RequestContent"/>. </param>
         public static implicit operator RequestContent(ModelWithRequiredNullableProperties modelWithRequiredNullableProperties)
         {
+            if (modelWithRequiredNullableProperties == null)
+            {
+                return null;
+            }
             Utf8JsonBinaryContent content = new Utf8JsonBinaryContent();
             content.JsonWriter.WriteObjectValue(modelWithRequiredNullableProperties, ModelSerializationExtensions.WireOptions);
             return content;
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ProjectedModel.Serialization.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ProjectedModel.Serialization.cs
index 75dc1aad68de..fc83f20f07aa 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ProjectedModel.Serialization.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ProjectedModel.Serialization.cs
@@ -134,6 +134,10 @@ protected virtual ProjectedModel PersistableModelCreateCore(BinaryData data, Mod
         /// <param name="projectedModel"> The <see cref="ProjectedModel"/> to serialize into <see cref="RequestContent"/>. </param>
         public static implicit operator RequestContent(ProjectedModel projectedModel)
         {
+            if (projectedModel == null)
+            {
+                return null;
+            }
             Utf8JsonBinaryContent content = new Utf8JsonBinaryContent();
             content.JsonWriter.WriteObjectValue(projectedModel, ModelSerializationExtensions.WireOptions);
             return content;
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ReturnsAnonymousModelResponse.Serialization.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ReturnsAnonymousModelResponse.Serialization.cs
index 092802278552..999c8993fbf5 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ReturnsAnonymousModelResponse.Serialization.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/ReturnsAnonymousModelResponse.Serialization.cs
@@ -122,6 +122,10 @@ protected virtual ReturnsAnonymousModelResponse PersistableModelCreateCore(Binar
         /// <param name="returnsAnonymousModelResponse"> The <see cref="ReturnsAnonymousModelResponse"/> to serialize into <see cref="RequestContent"/>. </param>
         public static implicit operator RequestContent(ReturnsAnonymousModelResponse returnsAnonymousModelResponse)
         {
+            if (returnsAnonymousModelResponse == null)
+            {
+                return null;
+            }
             Utf8JsonBinaryContent content = new Utf8JsonBinaryContent();
             content.JsonWriter.WriteObjectValue(returnsAnonymousModelResponse, ModelSerializationExtensions.WireOptions);
             return content;
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/RoundTripModel.Serialization.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/RoundTripModel.Serialization.cs
index 6eb941b8f900..d3c11e295c7e 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/RoundTripModel.Serialization.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/RoundTripModel.Serialization.cs
@@ -639,6 +639,10 @@ protected virtual RoundTripModel PersistableModelCreateCore(BinaryData data, Mod
         /// <param name="roundTripModel"> The <see cref="RoundTripModel"/> to serialize into <see cref="RequestContent"/>. </param>
         public static implicit operator RequestContent(RoundTripModel roundTripModel)
         {
+            if (roundTripModel == null)
+            {
+                return null;
+            }
             Utf8JsonBinaryContent content = new Utf8JsonBinaryContent();
             content.JsonWriter.WriteObjectValue(roundTripModel, ModelSerializationExtensions.WireOptions);
             return content;
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/Thing.Serialization.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/Thing.Serialization.cs
index 4dd6a48493ed..d67702d57298 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/Thing.Serialization.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Models/Thing.Serialization.cs
@@ -325,6 +325,10 @@ protected virtual Thing PersistableModelCreateCore(BinaryData data, ModelReaderW
         /// <param name="thing"> The <see cref="Thing"/> to serialize into <see cref="RequestContent"/>. </param>
         public static implicit operator RequestContent(Thing thing)
         {
+            if (thing == null)
+            {
+                return null;
+            }
             Utf8JsonBinaryContent content = new Utf8JsonBinaryContent();
             content.JsonWriter.WriteObjectValue(thing, ModelSerializationExtensions.WireOptions);
             return content;

From 7a104e6c78d9c7fd4e61228da08d980a5d693927 Mon Sep 17 00:00:00 2001
From: Wei Hu <huwe@microsoft.com>
Date: Tue, 5 Nov 2024 10:26:47 +0800
Subject: [PATCH 6/9] User Add for request headers instead of SetValue

---
 .../src/Providers/Abstraction/HttpRequestProvider.cs            | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs
index 37f0f6278f65..ef8f9cdb1a65 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs
@@ -28,7 +28,7 @@ public override HttpRequestApi FromExpression(ValueExpression original)
             => new HttpRequestProvider(original);
 
         public override MethodBodyStatement SetHeaders(IReadOnlyList<ValueExpression> arguments)
-            => Original.Property(nameof(PipelineRequest.Headers)).Invoke(nameof(RequestHeaders.SetValue), arguments).Terminate();
+            => Original.Property(nameof(PipelineRequest.Headers)).Invoke(nameof(RequestHeaders.Add), arguments).Terminate();
 
         public override MethodBodyStatement SetMethod(string httpMethod)
             => Original.Property(nameof(PipelineRequest.Method)).Assign(CreateRequestMethod(httpMethod)).Terminate();

From 06b72f71d9d39c6a82b0a0a4122e84b2cca8af24 Mon Sep 17 00:00:00 2001
From: Wei Hu <huwe@microsoft.com>
Date: Tue, 5 Nov 2024 12:07:57 +0800
Subject: [PATCH 7/9] fix local test generation and update tests

---
 .../BasicTypeSpecClient.RestClient.cs         | 56 +++++++++----------
 eng/scripts/typespec/Generate-Code.ps1        |  4 ++
 2 files changed, 32 insertions(+), 28 deletions(-)

diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
index eb6682ff07e3..8b18964bdbc5 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
@@ -41,8 +41,8 @@ internal HttpMessage CreateSayHiRequest(string headParameter, string queryParame
                 uri.AppendQuery("optionalQuery", optionalQuery, true);
             }
             request.Uri = uri;
-            request.Headers.SetValue("head-parameter", headParameter);
-            request.Headers.SetValue("Accept", "application/json");
+            request.Headers.Add("head-parameter", headParameter);
+            request.Headers.Add("Accept", "application/json");
             return message;
         }
 
@@ -56,9 +56,9 @@ internal HttpMessage CreateHelloAgainRequest(string p2, string p1, RequestConten
             uri.AppendPath("/againHi/", false);
             uri.AppendPath(p2, true);
             request.Uri = uri;
-            request.Headers.SetValue("p1", p1);
-            request.Headers.SetValue("Content-Type", "text/plain");
-            request.Headers.SetValue("Accept", "application/json");
+            request.Headers.Add("p1", p1);
+            request.Headers.Add("Content-Type", "text/plain");
+            request.Headers.Add("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -73,9 +73,9 @@ internal HttpMessage CreateNoContentTypeRequest(string p2, string p1, RequestCon
             uri.AppendPath("/noContentType/", false);
             uri.AppendPath(p2, true);
             request.Uri = uri;
-            request.Headers.SetValue("p1", p1);
-            request.Headers.SetValue("Content-Type", "application/json");
-            request.Headers.SetValue("Accept", "application/json");
+            request.Headers.Add("p1", p1);
+            request.Headers.Add("Content-Type", "application/json");
+            request.Headers.Add("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -89,7 +89,7 @@ internal HttpMessage CreateHelloDemo2Request(RequestContext context)
             uri.Reset(_endpoint);
             uri.AppendPath("/demoHi", false);
             request.Uri = uri;
-            request.Headers.SetValue("Accept", "application/json");
+            request.Headers.Add("Accept", "application/json");
             return message;
         }
 
@@ -102,8 +102,8 @@ internal HttpMessage CreateCreateLiteralRequest(RequestContent content, RequestC
             uri.Reset(_endpoint);
             uri.AppendPath("/literal", false);
             request.Uri = uri;
-            request.Headers.SetValue("Content-Type", "application/json");
-            request.Headers.SetValue("Accept", "application/json");
+            request.Headers.Add("Content-Type", "application/json");
+            request.Headers.Add("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -119,8 +119,8 @@ internal HttpMessage CreateHelloLiteralRequest(RequestContext context)
             uri.AppendPath(123.ToString(), true);
             uri.AppendQuery("p3", TypeFormatters.ConvertToString(true, null), true);
             request.Uri = uri;
-            request.Headers.SetValue("p1", "test");
-            request.Headers.SetValue("Accept", "application/json");
+            request.Headers.Add("p1", "test");
+            request.Headers.Add("Accept", "application/json");
             return message;
         }
 
@@ -134,7 +134,7 @@ internal HttpMessage CreateTopActionRequest(DateTimeOffset action, RequestContex
             uri.AppendPath("/top/", false);
             uri.AppendPath(action.ToString("O"), true);
             request.Uri = uri;
-            request.Headers.SetValue("Accept", "application/json");
+            request.Headers.Add("Accept", "application/json");
             return message;
         }
 
@@ -147,7 +147,7 @@ internal HttpMessage CreateTopAction2Request(RequestContext context)
             uri.Reset(_endpoint);
             uri.AppendPath("/top2", false);
             request.Uri = uri;
-            request.Headers.SetValue("Accept", "application/json");
+            request.Headers.Add("Accept", "application/json");
             return message;
         }
 
@@ -160,8 +160,8 @@ internal HttpMessage CreatePatchActionRequest(RequestContent content, RequestCon
             uri.Reset(_endpoint);
             uri.AppendPath("/patch", false);
             request.Uri = uri;
-            request.Headers.SetValue("Content-Type", "application/json");
-            request.Headers.SetValue("Accept", "application/json");
+            request.Headers.Add("Content-Type", "application/json");
+            request.Headers.Add("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -175,8 +175,8 @@ internal HttpMessage CreateAnonymousBodyRequest(RequestContent content, RequestC
             uri.Reset(_endpoint);
             uri.AppendPath("/anonymousBody", false);
             request.Uri = uri;
-            request.Headers.SetValue("Content-Type", "application/json");
-            request.Headers.SetValue("Accept", "application/json");
+            request.Headers.Add("Content-Type", "application/json");
+            request.Headers.Add("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -190,8 +190,8 @@ internal HttpMessage CreateFriendlyModelRequest(RequestContent content, RequestC
             uri.Reset(_endpoint);
             uri.AppendPath("/friendlyName", false);
             request.Uri = uri;
-            request.Headers.SetValue("Content-Type", "application/json");
-            request.Headers.SetValue("Accept", "application/json");
+            request.Headers.Add("Content-Type", "application/json");
+            request.Headers.Add("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -205,7 +205,7 @@ internal HttpMessage CreateAddTimeHeaderRequest(RequestContext context)
             uri.Reset(_endpoint);
             uri.AppendPath("/", false);
             request.Uri = uri;
-            request.Headers.SetValue("Repeatability-First-Sent", TypeFormatters.ConvertToString(DateTimeOffset.Now, "R"));
+            request.Headers.Add("Repeatability-First-Sent", TypeFormatters.ConvertToString(DateTimeOffset.Now, "R"));
             return message;
         }
 
@@ -218,8 +218,8 @@ internal HttpMessage CreateProjectedNameModelRequest(RequestContent content, Req
             uri.Reset(_endpoint);
             uri.AppendPath("/projectedName", false);
             request.Uri = uri;
-            request.Headers.SetValue("Content-Type", "application/json");
-            request.Headers.SetValue("Accept", "application/json");
+            request.Headers.Add("Content-Type", "application/json");
+            request.Headers.Add("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -233,7 +233,7 @@ internal HttpMessage CreateReturnsAnonymousModelRequest(RequestContext context)
             uri.Reset(_endpoint);
             uri.AppendPath("/returnsAnonymousModel", false);
             request.Uri = uri;
-            request.Headers.SetValue("Accept", "application/json");
+            request.Headers.Add("Accept", "application/json");
             return message;
         }
 
@@ -246,7 +246,7 @@ internal HttpMessage CreateGetUnknownValueRequest(string accept, RequestContext
             uri.Reset(_endpoint);
             uri.AppendPath("/unknown-value", false);
             request.Uri = uri;
-            request.Headers.SetValue("Accept", accept);
+            request.Headers.Add("Accept", accept);
             return message;
         }
 
@@ -259,8 +259,8 @@ internal HttpMessage CreateInternalProtocolRequest(RequestContent content, Reque
             uri.Reset(_endpoint);
             uri.AppendPath("/internalProtocol", false);
             request.Uri = uri;
-            request.Headers.SetValue("Content-Type", "application/json");
-            request.Headers.SetValue("Accept", "application/json");
+            request.Headers.Add("Content-Type", "application/json");
+            request.Headers.Add("Accept", "application/json");
             request.Content = content;
             return message;
         }
diff --git a/eng/scripts/typespec/Generate-Code.ps1 b/eng/scripts/typespec/Generate-Code.ps1
index fd87c760daa1..b71faf54942a 100644
--- a/eng/scripts/typespec/Generate-Code.ps1
+++ b/eng/scripts/typespec/Generate-Code.ps1
@@ -36,6 +36,8 @@ function Refresh-Build {
 $testProjectsLocalDir = Join-Path $packageRoot 'generator' 'TestProjects' 'Local'
 $basicTypespecTestProject = Join-Path $testProjectsLocalDir "Basic-TypeSpec"
 
+Push-Location $packageRoot
+
 Write-Host "Generating test projects ..."
 Refresh-Build
 
@@ -45,4 +47,6 @@ Invoke-LoggedCommand (Get-TspCommand "$basicTypespecTestProject/Basic-TypeSpec.t
 Write-Host "Building BasicTypeSpec" -ForegroundColor Cyan
 Invoke-LoggedCommand "dotnet build $packageRoot/generator/TestProjects/Local/Basic-TypeSpec/src/BasicTypeSpec.csproj"
 
+Pop-Location
+
 Write-Host 'Code generation is completed.'

From 7c723a472c8d1867bd88e73e2757570103de1bf4 Mon Sep 17 00:00:00 2001
From: Wei Hu <huwe@microsoft.com>
Date: Wed, 6 Nov 2024 09:41:30 +0800
Subject: [PATCH 8/9] use SetValue for headers to be consistent with MGC

---
 .../Abstraction/HttpRequestProvider.cs        |  2 +-
 .../BasicTypeSpecClient.RestClient.cs         | 56 +++++++++----------
 2 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs
index ef8f9cdb1a65..37f0f6278f65 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpRequestProvider.cs
@@ -28,7 +28,7 @@ public override HttpRequestApi FromExpression(ValueExpression original)
             => new HttpRequestProvider(original);
 
         public override MethodBodyStatement SetHeaders(IReadOnlyList<ValueExpression> arguments)
-            => Original.Property(nameof(PipelineRequest.Headers)).Invoke(nameof(RequestHeaders.Add), arguments).Terminate();
+            => Original.Property(nameof(PipelineRequest.Headers)).Invoke(nameof(RequestHeaders.SetValue), arguments).Terminate();
 
         public override MethodBodyStatement SetMethod(string httpMethod)
             => Original.Property(nameof(PipelineRequest.Method)).Assign(CreateRequestMethod(httpMethod)).Terminate();
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
index 8b18964bdbc5..eb6682ff07e3 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/BasicTypeSpecClient.RestClient.cs
@@ -41,8 +41,8 @@ internal HttpMessage CreateSayHiRequest(string headParameter, string queryParame
                 uri.AppendQuery("optionalQuery", optionalQuery, true);
             }
             request.Uri = uri;
-            request.Headers.Add("head-parameter", headParameter);
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("head-parameter", headParameter);
+            request.Headers.SetValue("Accept", "application/json");
             return message;
         }
 
@@ -56,9 +56,9 @@ internal HttpMessage CreateHelloAgainRequest(string p2, string p1, RequestConten
             uri.AppendPath("/againHi/", false);
             uri.AppendPath(p2, true);
             request.Uri = uri;
-            request.Headers.Add("p1", p1);
-            request.Headers.Add("Content-Type", "text/plain");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("p1", p1);
+            request.Headers.SetValue("Content-Type", "text/plain");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -73,9 +73,9 @@ internal HttpMessage CreateNoContentTypeRequest(string p2, string p1, RequestCon
             uri.AppendPath("/noContentType/", false);
             uri.AppendPath(p2, true);
             request.Uri = uri;
-            request.Headers.Add("p1", p1);
-            request.Headers.Add("Content-Type", "application/json");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("p1", p1);
+            request.Headers.SetValue("Content-Type", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -89,7 +89,7 @@ internal HttpMessage CreateHelloDemo2Request(RequestContext context)
             uri.Reset(_endpoint);
             uri.AppendPath("/demoHi", false);
             request.Uri = uri;
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             return message;
         }
 
@@ -102,8 +102,8 @@ internal HttpMessage CreateCreateLiteralRequest(RequestContent content, RequestC
             uri.Reset(_endpoint);
             uri.AppendPath("/literal", false);
             request.Uri = uri;
-            request.Headers.Add("Content-Type", "application/json");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Content-Type", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -119,8 +119,8 @@ internal HttpMessage CreateHelloLiteralRequest(RequestContext context)
             uri.AppendPath(123.ToString(), true);
             uri.AppendQuery("p3", TypeFormatters.ConvertToString(true, null), true);
             request.Uri = uri;
-            request.Headers.Add("p1", "test");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("p1", "test");
+            request.Headers.SetValue("Accept", "application/json");
             return message;
         }
 
@@ -134,7 +134,7 @@ internal HttpMessage CreateTopActionRequest(DateTimeOffset action, RequestContex
             uri.AppendPath("/top/", false);
             uri.AppendPath(action.ToString("O"), true);
             request.Uri = uri;
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             return message;
         }
 
@@ -147,7 +147,7 @@ internal HttpMessage CreateTopAction2Request(RequestContext context)
             uri.Reset(_endpoint);
             uri.AppendPath("/top2", false);
             request.Uri = uri;
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             return message;
         }
 
@@ -160,8 +160,8 @@ internal HttpMessage CreatePatchActionRequest(RequestContent content, RequestCon
             uri.Reset(_endpoint);
             uri.AppendPath("/patch", false);
             request.Uri = uri;
-            request.Headers.Add("Content-Type", "application/json");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Content-Type", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -175,8 +175,8 @@ internal HttpMessage CreateAnonymousBodyRequest(RequestContent content, RequestC
             uri.Reset(_endpoint);
             uri.AppendPath("/anonymousBody", false);
             request.Uri = uri;
-            request.Headers.Add("Content-Type", "application/json");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Content-Type", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -190,8 +190,8 @@ internal HttpMessage CreateFriendlyModelRequest(RequestContent content, RequestC
             uri.Reset(_endpoint);
             uri.AppendPath("/friendlyName", false);
             request.Uri = uri;
-            request.Headers.Add("Content-Type", "application/json");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Content-Type", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -205,7 +205,7 @@ internal HttpMessage CreateAddTimeHeaderRequest(RequestContext context)
             uri.Reset(_endpoint);
             uri.AppendPath("/", false);
             request.Uri = uri;
-            request.Headers.Add("Repeatability-First-Sent", TypeFormatters.ConvertToString(DateTimeOffset.Now, "R"));
+            request.Headers.SetValue("Repeatability-First-Sent", TypeFormatters.ConvertToString(DateTimeOffset.Now, "R"));
             return message;
         }
 
@@ -218,8 +218,8 @@ internal HttpMessage CreateProjectedNameModelRequest(RequestContent content, Req
             uri.Reset(_endpoint);
             uri.AppendPath("/projectedName", false);
             request.Uri = uri;
-            request.Headers.Add("Content-Type", "application/json");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Content-Type", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }
@@ -233,7 +233,7 @@ internal HttpMessage CreateReturnsAnonymousModelRequest(RequestContext context)
             uri.Reset(_endpoint);
             uri.AppendPath("/returnsAnonymousModel", false);
             request.Uri = uri;
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             return message;
         }
 
@@ -246,7 +246,7 @@ internal HttpMessage CreateGetUnknownValueRequest(string accept, RequestContext
             uri.Reset(_endpoint);
             uri.AppendPath("/unknown-value", false);
             request.Uri = uri;
-            request.Headers.Add("Accept", accept);
+            request.Headers.SetValue("Accept", accept);
             return message;
         }
 
@@ -259,8 +259,8 @@ internal HttpMessage CreateInternalProtocolRequest(RequestContent content, Reque
             uri.Reset(_endpoint);
             uri.AppendPath("/internalProtocol", false);
             request.Uri = uri;
-            request.Headers.Add("Content-Type", "application/json");
-            request.Headers.Add("Accept", "application/json");
+            request.Headers.SetValue("Content-Type", "application/json");
+            request.Headers.SetValue("Accept", "application/json");
             request.Content = content;
             return message;
         }

From 1885659470d51f85f2d3015864abe1bcbb7460ca Mon Sep 17 00:00:00 2001
From: Wei Hu <huwe@microsoft.com>
Date: Thu, 7 Nov 2024 09:29:41 +0800
Subject: [PATCH 9/9] revert to default for cancellationToken in
 ProcessMessage, will handle it properly later

---
 .../src/Providers/Abstraction/HttpPipelineProvider.cs         | 4 ++--
 .../src/Generated/Internal/ClientPipelineExtensions.cs        | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
index 3fc685ea0da4..05d90170eea4 100644
--- a/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
+++ b/eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/Abstraction/HttpPipelineProvider.cs
@@ -41,9 +41,9 @@ public override ValueExpression PerRetryPolicy(params ValueExpression[] argument
         public override ClientPipelineApi ToExpression() => this;
 
         public override MethodBodyStatement Send(HttpMessageApi message, HttpRequestOptionsApi options)
-            => Original.Invoke(nameof(HttpPipeline.Send), [message, options.Property(nameof(RequestContext.CancellationToken))]).Terminate();
+            => Original.Invoke(nameof(HttpPipeline.Send), [message, Default]).Terminate();
 
         public override MethodBodyStatement SendAsync(HttpMessageApi message, HttpRequestOptionsApi options)
-            => Original.Invoke(nameof(HttpPipeline.SendAsync), [message, options.Property(nameof(RequestContext.CancellationToken))], true).Terminate();
+            => Original.Invoke(nameof(HttpPipeline.SendAsync), [message, Default], true).Terminate();
     }
 }
diff --git a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs
index 6a2867133985..0df6739148f7 100644
--- a/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs
+++ b/eng/packages/http-client-csharp/generator/TestProjects/Local/Basic-TypeSpec/src/Generated/Internal/ClientPipelineExtensions.cs
@@ -16,7 +16,7 @@ internal static partial class ClientPipelineExtensions
     {
         public static async ValueTask<Response> ProcessMessageAsync(this HttpPipeline pipeline, HttpMessage message, RequestContext context)
         {
-            await pipeline.SendAsync(message, context.CancellationToken).ConfigureAwait(false);
+            await pipeline.SendAsync(message, default).ConfigureAwait(false);
 
             if (message.Response.IsError && (context?.ErrorOptions & ErrorOptions.NoThrow) != ErrorOptions.NoThrow)
             {
@@ -29,7 +29,7 @@ public static async ValueTask<Response> ProcessMessageAsync(this HttpPipeline pi
 
         public static Response ProcessMessage(this HttpPipeline pipeline, HttpMessage message, RequestContext context)
         {
-            pipeline.Send(message, context.CancellationToken);
+            pipeline.Send(message, default);
 
             if (message.Response.IsError && (context?.ErrorOptions & ErrorOptions.NoThrow) != ErrorOptions.NoThrow)
             {