Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-generated Network for August release #4675

Closed
wants to merge 4 commits into from
Closed

Re-generated Network for August release #4675

wants to merge 4 commits into from

Conversation

anton-evseev
Copy link
Contributor

Description

Based on: Azure/azure-rest-api-specs#3635

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda
dsgouda suggested changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great for the most part, need some questions answered

src/SDKs/Network/Management.Network/Microsoft.Azure.Management.Network.csproj Outdated
@@ -7,11 +7,15 @@
<PackageId>Microsoft.Azure.Management.Network</PackageId>
<Description>Provides management capabilities for Network services.</Description>
<AssemblyName>Microsoft.Azure.Management.Network</AssemblyName>
<Version>19.2.0-preview</Version>
<Version>20.0.0-preview</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikhailTryakhov any word on when you are planning to release a stable version here? Any reason why you plan to do a major version bump here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda I think we need publish stable version when all know issues will be fixed. now we have one in brooklyn team. let's I test all swagger issues we have (in optional jobs for example), fix them and next Ignite version will be stable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you are in preview you cannot bump up major version

src/SDKs/Network/Network.Tests/Tests/LoadBalancerTests.cs
@@ -1435,141 +1435,5 @@ public void LoadBalancerNatPoolTest()
networkManagementClient.PublicIPAddresses.Delete(resourceGroupName, lbPublicIpName);
}
}

[Fact(Skip="Disable tests")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these being deleted? Was this service deprecated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OutboundNatRules were never made public
Azure/azure-rest-api-specs#3592

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specific comment: Azure/azure-rest-api-specs#3592 (comment)

shahabhijeet
shahabhijeet suggested changes Aug 20, 2018
View reviewed changes
src/SDKs/Network/Management.Network/Microsoft.Azure.Management.Network.csproj Outdated
@@ -7,11 +7,15 @@
<PackageId>Microsoft.Azure.Management.Network</PackageId>
<Description>Provides management capabilities for Network services.</Description>
<AssemblyName>Microsoft.Azure.Management.Network</AssemblyName>
<Version>19.2.0-preview</Version>
<Version>20.0.0-preview</Version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you are in preview you cannot bump up major version

@anton-evseev
Copy link
Contributor Author

@shahabhijeet @dsgouda set file version to 19.3.0, left assembly version as 19.0.2.0 (I remember in previous PR I was asked to leave it as is)

dsgouda
dsgouda approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Aug 21, 2018

@shahabhijeet any additional feedback?

@MikhailTryakhov
Copy link
Contributor

close because waiting for changes in LB

@anton-evseev
Copy link
Contributor Author

I'll update this PR once LB changes (Azure/azure-rest-api-specs#3697) are merged in master. That way we'll avoid breaking changes in September release

@dsgouda
Copy link
Contributor

dsgouda commented Aug 22, 2018

Closing PR per @MikhailTryakhov 's comment

@dsgouda dsgouda closed this Aug 22, 2018
@dsgouda
Copy link
Contributor

dsgouda commented Aug 22, 2018

@number213 Feel free to open a new PR when you are ready, I'll be happy to take a look

@anton-evseev anton-evseev mentioned this pull request Aug 24, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikhailTryakhov MikhailTryakhov MikhailTryakhov left review comments

@shahabhijeet shahabhijeet shahabhijeet requested changes

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anton-evseev @dsgouda @MikhailTryakhov @shahabhijeet