added issue api and tests #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsgouda @shahabhijeet @promoisha can you take a look? |
dsgouda
suggested changes
Apr 20, 2018
| @@ -15,6 +15,9 @@ internal static partial class SdkInfo | |||
| new Tuple<string, string, string>("ApiManagement", "ApiDiagnostic", "2018-01-01"), | |||
| new Tuple<string, string, string>("ApiManagement", "ApiDiagnosticLogger", "2018-01-01"), | |||
| new Tuple<string, string, string>("ApiManagement", "ApiExport", "2018-01-01"), | |||
| new Tuple<string, string, string>("ApiManagement", "ApiIssue", "2018-01-01"), | |||
There was a problem hiding this comment.
Please run msbuild build.proj /t:build /p:Scope=SDKs\ApiManagement
and commit changes to the .props file
There was a problem hiding this comment.
built again. there is no change in api version and no change in .props file
| @@ -9,8 +9,8 @@ | |||
| [assembly: AssemblyTitle("Microsoft Azure API Management Resource Management Library")] | |||
| [assembly: AssemblyDescription("Provides Api management capabilities for Microsoft Azure.")] | |||
|
|
|||
| [assembly: AssemblyVersion("4.0.0.0")] | |||
| [assembly: AssemblyFileVersion("4.0.0.0")] | |||
| [assembly: AssemblyVersion("4.0.1.0")] | |||
There was a problem hiding this comment.
Please do not update the AssemblyVersion here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for issue api and policy in non encoded xml format
Relevant rest spec pr
Azure/azure-rest-api-specs#2806
Azure/azure-rest-api-specs#2893
Azure/azure-rest-api-specs#2881
Azure/azure-rest-api-specs#2882
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.