[Service Bus Functions Extensions] Actions Mock Support #25489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The focus of these changes is to add a protected constructor to the `ServiceBusMessageActions` class to support mocking for test scenarios.
|
API changes have been detected in API changes + protected ServiceBusMessageActions(); |
|
Hello @jsquire! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
pakrym
approved these changes
Nov 23, 2021
| /// This constructor exists only to support mocking. When used, class state is not fully initialized, and | ||
| /// will not function correctly; virtual members are meant to be mocked. | ||
| ///</remarks> | ||
| protected ServiceBusMessageActions() |
There was a problem hiding this comment.
I think we will need to add this for the derived class too - ServiceBusSesssionMessageActions.
There was a problem hiding this comment.
My bad; didn't see it when I patched this. I'll push that out in another PR.
|
Fixes #25405 |
ghost
pushed a commit
that referenced
this pull request
Nov 23, 2021
# Summary The focus of these changes is to add a protected constructor to the `ServiceBusSessionMessageActions` class to support mocking for test scenarios. # References and Related - [Twitter thread discussing mocking difficulties](https://twitter.com/rolandkru/status/1462756372651593733) - [[Service Bus Functions Extensions] Actions Mock Support (#25489)](#25489)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to add a protected constructor to the
ServiceBusMessageActionsclass to support mocking for test scenarios.References and Related