Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Document Translation] Removing the word All from GetAll [Translation/Document] Statuses #23332

Merged
merged 7 commits into from
Aug 18, 2021

Conversation

AhmedLeithy
Copy link
Member

GetAllTranslationStatuses --> GetTranslationStatuses
GetAllDocumentStatuses --> GetDocumentStatuses

This is in response to the architects' comments as per #23088 .

Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious: I see some recorded test with renames and other that were deleted and generated again. I wonder why the combination?
It might be better to just do the renames on the files so it is easier to review that nothing else changed

@AhmedLeithy
Copy link
Member Author

curious: I see some recorded test with renames and other that were deleted and generated again. I wonder why the combination?

I had initially tried to rerun all the tests, but there were a few that didn't succeed (because of the Azure Active Directory issue), so I renamed the ones that were left over.

But yea, I agree, it's a bit weird and inconsistent. I've renamed all of them instead.

@maririos maririos merged commit 77205be into Azure:main Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants