Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf, Stress] Case-insensitive command-line parsing #16965

Merged
merged 8 commits into from
Nov 17, 2020
Merged

[Perf, Stress] Case-insensitive command-line parsing #16965

merged 8 commits into from
Nov 17, 2020

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Nov 13, 2020 •
edited
Loading

This was referenced Nov 14, 2020
Closed
Closed
Closed
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

@weshaggard
Copy link
Member

/azp run net - template - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@weshaggard
Copy link
Member

@mikeharder something looks to be wrong with the path triggers for the template pipeline. https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/template/ci.yml#L21 I don't see anything obvious but perhaps there is a weird issue with file casing.

@mikeharder
Copy link
Member Author

@weshaggard: I was jus about to debug why the pipelines are not triggering for this PR.

@mikeharder
Copy link
Member Author

/azp list

@openapi-assignment-bot
Copy link

/azp list

Unrecognized OpenAPI bot command (list).
Try sdkautomation or run instead.

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@mikeharder
Copy link
Member Author

/azp run net - template - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mikeharder mikeharder merged commit 8153513 into Azure:master Nov 17, 2020
@mikeharder mikeharder deleted the perf-stress-case-insensitive branch November 17, 2020 01:15
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
@mikeharder @annelo-msft
[Perf, Stress] Case-insensitive command-line parsing (Azure#16965)
4d524b5 
- Perf and Stress frameworks should use case-insensitive command-line parsing
- Refactor common code into PerfStressUtilities shared source
- Add PerfOptions.StatusInterval to align with StressOptions
- Fixes Azure#16850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths approved these changes

@pakrym pakrym pakrym approved these changes

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@danieljurek danieljurek Awaiting requested review from danieljurek

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@weshaggard weshaggard Awaiting requested review from weshaggard

@MiYanni MiYanni Awaiting requested review from MiYanni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Perf, Stress] Command-line test name should be matched case-insensitive
4 participants
@mikeharder @weshaggard @heaths @pakrym