Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RoleDefinitions mutable #14314

Merged

Conversation

christothes
Copy link
Member

fixes #12702

@christothes christothes requested review from heaths and schaabs August 18, 2020 18:26
@christothes christothes self-assigned this Aug 18, 2020
@ghost ghost added the KeyVault label Aug 18, 2020
@christothes christothes added the Client This issue points to a problem in the data-plane of the library. label Aug 18, 2020
@christothes christothes merged commit 84d10d6 into Azure:master Aug 18, 2020
@pakrym
Copy link
Contributor

pakrym commented Aug 18, 2020

Sorry I didn't catch this PR earlier, there is a generator feature for this: https://github.com/Azure/autorest.csharp/blob/9eeed94997ff4ddbe5a65ca806ce4315b06c50b5/test/TestProjects/TypeSchemaMapping/Customized/ModelWithCustomUsageViaAttribute.cs#L8

You can annotate the model and provide the intended usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KeyVault] Make RBAC models mutable to support full CRUD for RoleDefinitions
3 participants