Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate Event Grid .NET SDK for 2020-04-01-preview to include new properties changes #12074

Merged
merged 3 commits into from
May 18, 2020

Conversation

ahamad-MS
Copy link
Contributor

@ahamad-MS
Copy link
Contributor Author

Hello @isra-fel @erich-wang ... Can you please help reviewing this change?

Also, it seem check-enforcer is stuck in running state since yesterday. Is this infra issue?

thanks

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Check-enforcer was yellow because test mac os was failed, and that's because there's something wrong with test environment. I'll get back to you when I find a solution

@isra-fel
Copy link
Member

Hello, I just merged a PR to skip that test: #12097
Could you rebase latest master?

@ahamad-MS
Copy link
Contributor Author

Hello @isra-fel .. Thanks for merging the test fix.. I rebased and resubmitted. All checks passe snow. Kindly merge the change.

thanks

@ahamad-MS ahamad-MS requested a review from isra-fel May 16, 2020 17:34
@isra-fel
Copy link
Member

/azp run net - eventgrid - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel merged commit d2a8d7f into Azure:master May 18, 2020
@ahamad-MS ahamad-MS deleted the master branch June 2, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants