Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Microsoft.Azure.Management.LabServices.Tests to SDK Type #9982

Closed
wantedfast opened this issue Feb 14, 2020 · 4 comments
Closed

Update Microsoft.Azure.Management.LabServices.Tests to SDK Type #9982

wantedfast opened this issue Feb 14, 2020 · 4 comments
Assignees
@tzhanl @nickzhums
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Lab Services Mgmt This issue is related to a management-plane library.

Comments

@wantedfast
Copy link
Contributor

PR#6536 update Mgmt SDK project to SDK type. But Microsoft.Azure.Management.LabServices.Tests was missed. The whole solution not working now. Let's update this project to SDK type.

Replace
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Azure.Management.LabServices.Tests", "tests\Microsoft.Azure.Management.LabServices.Tests.csproj", "{DC1024AF-4E20-4E65-9ED8-09CC26385B8B}"

To
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Azure.Management.LabServices.Tests", "tests\Microsoft.Azure.Management.LabServices.Tests.csproj", "{DC1024AF-4E20-4E65-9ED8-09CC26385B8B}"
At line 6 in Microsoft.Azure.Management.LabServices.sln file.
@triage-new-issues triage-new-issues bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 14, 2020
@wantedfast wantedfast mentioned this issue Feb 14, 2020
Closed
@jsquire jsquire added bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Lab Services Mgmt This issue is related to a management-plane library. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Feb 14, 2020
@nickzhums
Copy link
Contributor

@dingmeng-xue could you help take a look a this

@wantedfast
Copy link
Contributor Author

Hi @chidozieononiwu ,

Can we update the project GUID according this PR#6536

@chidozieononiwu
Copy link
Member

I guess you can if that makes it build. But PR#6536 did not update that. It just moved the files from the directory src to the directory sdk. The test project for Labservices has used ToolsVersion="15.0" and that GUID before the PR. See here. @isra-fel do you know if its Ok to update this?

@wantedfast
Copy link
Contributor Author

Since PR #10656 merged, would close this one.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tzhanl tzhanl

@nickzhums nickzhums

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Lab Services Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jsquire @wantedfast @chidozieononiwu @tzhanl @nickzhums