Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] CI should not run 'net - client - ci' for mgmt related PR #7388

Closed
erich-wang opened this issue Aug 23, 2019 · 3 comments
Closed

[BUG] CI should not run 'net - client - ci' for mgmt related PR #7388

erich-wang opened this issue Aug 23, 2019 · 3 comments
Assignees
@chidozieononiwu
Labels
EngSys This issue is impacting the engineering system.

Comments

@erich-wang
Copy link
Member

It seems that CI runs 'net - client - ci' although the change is mgmt related only, for example:
#7363.
@triage-new-issues triage-new-issues bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 23, 2019
@kaerm kaerm added the EngSys This issue is impacting the engineering system. label Aug 26, 2019
@triage-new-issues triage-new-issues bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 26, 2019
@kaerm kaerm added the Client This issue points to a problem in the data-plane of the library. label Aug 26, 2019
@isra-fel
Copy link
Member

Hello @kaerm , is there an ETA for this issue? It is breaking several management plain PRs.

Thanks

@kurtzeborn kurtzeborn removed the Client This issue points to a problem in the data-plane of the library. label Aug 27, 2019
@kurtzeborn
Copy link
Member

Once we have unified pipelines for .Net this will go away so putting it under that epic. That said, we shouldn't be having failures in client PR validation if the changes are only to management libraries. @chidozieononiwu, could you take a look at why this was failing?

@chidozieononiwu
Copy link
Member

chidozieononiwu commented Sep 6, 2019 •
edited
Loading

Fixed with net - client - ci triggers.
Changes in eng/mgmt, eng/mgmt.proj, eng/pipelines/mgmt.yml, eng/pipelines/templates/jobs/archetype-sdk-mgmt.yml will no longer trigger net - client - ci

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chidozieononiwu chidozieononiwu

Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@isra-fel @erich-wang @kurtzeborn @kaerm @chidozieononiwu