Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Apply link metadata for the maximum batch message count #44916

Open
jsquire opened this issue Jul 9, 2024 · 1 comment
Open
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone

Comments

@jsquire
Copy link
Member

jsquire commented Jul 9, 2024

Problem statement

There is a maximum number of items that the service will accept in a single operation, regardless of any size considerations. At the time of writing, the Service Bus service will reject any request containing more than 4,500 messages. Because the service doesn't communicate the object limit, the client library is unable to validate that constraint or provide a guided development experience for ensuring safe limits.

There is an open request for the service to add a new link property that exposes the maximum batch message count on an AMQP link so that callers can dynamically discover the service limits.

Current work-around

The CreateMessageBatchOptions type is currently hardcoding the 4,500 message limit in order to ensure that the client library does not allow callers to create batches which cannot be successfully published.

Scope of work

  • Update AmqpSender to consume the maximum batch message count when a link is opened, following the same pattern used for the maximum message size, setting the MaxMessageCount property.

Success criteria

  • The MaxMessageCount property of AmqpSender is populated dynamically from AMQP link metadata and is updated each time a link is opened.
  • The Service Bus live test suite continues to pass reliably.

References and related

@jsquire jsquire added Service Bus Client This issue points to a problem in the data-plane of the library. labels Jul 9, 2024
@jsquire jsquire added this to the Backlog milestone Jul 9, 2024
@github-actions github-actions bot added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Jul 9, 2024
@jsquire jsquire removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Jul 9, 2024
@jsquire jsquire moved this to Planned in Azure SDK for Service Bus Jul 9, 2024
@jsquire
Copy link
Member Author

jsquire commented Jul 9, 2024

depends on #709

@Azure Azure deleted a comment from github-actions bot Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
Status: Planned
Development

No branches or pull requests

2 participants