Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Add AddAzureMonitorLogExporter extension method on LoggerProviderBuilder #44464

Closed
joegoldman2 opened this issue Jun 8, 2024 · 2 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@joegoldman2
Copy link

Library name

Azure.Monitor.OpenTelemetry.Exporter

Please describe the feature.

Summary

Following open-telemetry/opentelemetry-dotnet#5648, I think Azure.Monitor.OpenTelemetry.Exporter should provide a new extension method to configure the Azure Monitor log exporter on LoggerProviderBuilder (in the same way that AddAzureMonitorTraceExporter exists on TracerProviderBuilder and AddAzureMonitorMetricExporter exists for MeterProviderBuilder).

API Proposal

namespace Azure.Monitor.OpenTelemetry.Exporter
{
    public static class AzureMonitorExporterExtensions
    {
+        public static LoggerProviderBuilder AddAzureMonitorLogExporter(
+            this LoggerProviderBuilder builder,
+            Action<AzureMonitorExporterOptions> configure = null,
+            TokenCredential credential = null)
    }
}

In a second phase, once this new API is available, perhaps OpenTelemetryLoggerOptions.AddAzureMonitorLogExporter should be deprecated.

cc @CodeBlanch, @lmolkova

@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. labels Jun 8, 2024
Copy link

github-actions bot commented Jun 8, 2024

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @cijothomas @rajkumar-rangaraj @reyang @TimothyMothra @vishweshbankwar.

@cijothomas cijothomas added feature-request This issue requires a new behavior in the product in order be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 10, 2024
@TimothyMothra
Copy link
Contributor

Thanks for the reminder! This is already on our radar. We're waiting for the OTel 1.9.0 release which should be by the end of this week.
Assuming schedules line up, this should make it into our July beta release. :)

@TimothyMothra TimothyMothra self-assigned this Jun 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

3 participants