Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] WrapKeyInternal in Azure.Storage.Blobs calls wrong method #42160

Closed
yuopolev opened this issue Feb 23, 2024 · 2 comments · Fixed by #45352
Closed

[BUG] WrapKeyInternal in Azure.Storage.Blobs calls wrong method #42160

yuopolev opened this issue Feb 23, 2024 · 2 comments · Fixed by #45352
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)

Comments

@yuopolev
Copy link

Library name and version

Azure.Storage.Blobs

Describe the bug

image

'WrapKeyInternal' in SpecializedBlobExtensions in Azure.Storage.Blobs calls 'UnwrapKey' in case of non-async call.

Expected behavior

'WrapKeyInternal' should wrap key independently of being called as async or sync.

If 'sync' branch part is not used at all and not covered in tests, hten it should be removed, otherwise this needs to be fixed and do wrap.

Actual behavior

'WrapKeyInternal' wraps key in case it is called as async, and unwraps (?) key in case it is called as sync.

Reproduction Steps

This is obvious code defect, can be seem in sources.

Environment

No response
@jsquire jsquire added Storage Storage Service (Queues, Blobs, Files) Service Attention Workflow: This issue is responsible by Azure service team. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Feb 23, 2024
@jsquire
Copy link
Member

jsquire commented Feb 23, 2024

Thank you for your feedback. Tagging and routing to the team member best able to assist.
//cc: @xgithubtriage

@nickliu-msft nickliu-msft mentioned this issue Aug 5, 2024
Merged
@nickliu-msft
Copy link
Member

Hi we're working on a fix in our next coming release

@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
3 participants
@jsquire @yuopolev @nickliu-msft