Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InteractiveBrowserCredential preference to use system browser or modal dialog #34576

Closed
thenextman opened this issue Feb 27, 2023 · 3 comments · Fixed by #34095
Closed

InteractiveBrowserCredential preference to use system browser or modal dialog #34576

thenextman opened this issue Feb 27, 2023 · 3 comments · Fixed by #34095
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@thenextman
Copy link

Library name

Azure.Identity

Please describe the feature.

The documentation for InteractiveBrowserCredential says (emphasis mine):

launches the system default browser to interactively authenticate a user

In my experience, if my Windows desktop application targets .NET 6 the system browser is launched. However if we target .NET 4.8, a modal popup is shown with an embedded browser.

Using the system browser is (in my case) a better user experience, and from a cursory look it seems like this is an option in MSAL. Is it possible to get this choice exposed via the InteractiveBrowserCredentialOptions (or otherwise)?

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 27, 2023
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Feb 27, 2023
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 27, 2023
@jsquire
Copy link
Member

jsquire commented Feb 27, 2023

//cc: @christothes

@jsquire
Copy link
Member

jsquire commented Feb 27, 2023

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@jsquire jsquire added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Feb 27, 2023
@christothes christothes added the feature-request This issue requires a new behavior in the product in order be resolved. label Mar 1, 2023
@thenextman
Copy link
Author

thenextman commented Mar 1, 2023

The samples get us part of the way there, but ultimately it becomes necessary to reproduce much of the behaviour of the existing InteractiveBrowserCredential and MSAL public client to affect what is really a one-line change (adding the WithUseEmbeddedWebView call when getting interactive credentials).

I understand that MSAL is an implementation detail but my feeling is this would be a useful and relevant option for InteractiveBrowserCredentials. For certain classes of application, the system browser is far superior to using the embedded one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants