Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address architects feedback #23088

Closed
maririos opened this issue Aug 3, 2021 · 1 comment
Closed

Address architects feedback #23088

maririos opened this issue Aug 3, 2021 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Translator

Comments

@maririos
Copy link
Member

maririos commented Aug 3, 2021

Feedback:

  • Rename:
    • GetAllTranslationStatuses -> GetTranslationStatuses (async too)
    • GetAllDocumentStatuses -> GetDocumentStatuses (async too)
    • (.NET) TranslationFilter -> GetTranslationStatusesOptions, this applies too for DocumentFilter
    • Cancelled -> Cancel, for methods and types. Avoid CancellationToken as it is a .NET type
  • Consider renaming (maybe for Python):
    • (.NET) DocumentStatus -> DocumentStatusResult (status alone implies an enum.. like TranslationDocumentStatus).
    • (.NET) TranslationStatus -> TranslationStatusResult
    • (.NET) DocumentStatus.TranslatedTo -> DocumentStatus.TranslatedToLanguageCode
    • FileFormat -> DocumentTranslationFileFormat
  • Design:
@maririos
Copy link
Member Author

Individual issues have been created for each of these tasks

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Translator
Projects
None yet
Development

No branches or pull requests

1 participant