Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial .NET architects review #22658

Closed
maririos opened this issue Jul 14, 2021 · 3 comments
Closed

Initial .NET architects review #22658

maririos opened this issue Jul 14, 2021 · 3 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Translator
Milestone

Comments

@maririos
Copy link
Member

No description provided.

@maririos maririos added Client This issue points to a problem in the data-plane of the library. Cognitive - Translator labels Jul 14, 2021
@maririos maririos added this to the [2021] August milestone Jul 14, 2021
@maririos maririos self-assigned this Jul 14, 2021
@maririos
Copy link
Member Author

@maririos
Copy link
Member Author

maririos commented Aug 3, 2021

Feedback:

  • Rename:
    • GetAllTranslationStatuses -> GetTranslationStatuses (async too)
    • GetAllDocumentStatuses -> GetDocumentStatuses (async too)
    • TranslationFilter -> GetTranslationStatusesOptions
    • Cancelled -> Cancel, same for ing
  • Consider renaming:
    • DocumentStatus -> DocumentStatusResult (status alone implies an enum.. like TranslationDocumentStatus).
    • TranslationStatus -> TranslationStatusResult
    • DocumentStatus.TranslatedTo -> DocumentStatus.TranslatedToLanguageCode
    • FileFormat -> DocumentTranslationFileFormat
  • Design:

@maririos
Copy link
Member Author

maririos commented Aug 3, 2021

Issue to address feedback: #23088

@maririos maririos closed this as completed Aug 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Translator
Projects
None yet
Development

No branches or pull requests

1 participant