Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FormRecognizer] Allow support for older service versions #19132

Closed
kinelski opened this issue Mar 2, 2021 · 1 comment
Closed

[FormRecognizer] Allow support for older service versions #19132

kinelski opened this issue Mar 2, 2021 · 1 comment
Assignees
@maririos
Labels
blocking-release Blocks release bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Milestone
[2021] May

Comments

@kinelski
Copy link
Member

kinelski commented Mar 2, 2021

Currently only the latest service version can be targeted in the Form Recognizer client. We do have a Version enum that's set in the client options, but it's not used internally.
@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. bug This issue requires a change to an existing behavior in the product in order to be resolved. Cognitive - Form Recognizer labels Mar 2, 2021
@kinelski kinelski added this to the [2021] April milestone Mar 2, 2021
@kinelski kinelski mentioned this issue Mar 2, 2021
Closed
@kinelski kinelski self-assigned this Mar 12, 2021
@maririos maririos modified the milestones: [2021] April, [2021] May Apr 1, 2021
@maririos maririos added the blocking-release Blocks release label Apr 14, 2021
@maririos maririos mentioned this issue Apr 14, 2021
Closed
@kinelski kinelski mentioned this issue Apr 20, 2021
Closed
@maririos maririos assigned maririos and unassigned kinelski Apr 27, 2021
@maririos
Copy link
Member

maririos commented Apr 28, 2021 •
edited
Loading

The current plan is:

  • Apply transform to have multi-version support
  • Enable multi-version tests for FormTrainingClient
  • Enable multi-version tests for FormRecognizerClient
  • Enable multi-version tests for OperationLiveTest
  • Update methods docstrings to include information about the version
  • Update Model properties docstrings to include information about the version
  • Update Readme with table on version support like Python does
  • Update changelog

This was referenced Apr 28, 2021
Merged
Merged
Merged
Merged
Merged
Merged
@maririos maririos closed this as completed May 5, 2021
@maririos maririos mentioned this issue May 5, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maririos maririos

Labels
blocking-release Blocks release bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Projects
None yet
Milestone
[2021] May
Development

No branches or pull requests
2 participants
@kinelski @maririos