[MetricsAdvisor] Add tests for extra Get call in the Create methods

[kinelski]

We need to test the behavior when the first call (create) succeeds and the last call (get) fails. We can probably do it by mocking our client.

Methods to test:

• CreateDataFeed
• CreateDetectionConfiguration
• CreateAlertConfiguration
• CreateHook
• AddFeedback

Note: maybe only applicable to CreateDataFeed depending on the outcome of #18480.

[ghost]

Hi @kinelski. There hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by removing the no-recent-activity label. Otherwise, we'll close this out in 7 days.

[ghost]

Hi @kinelski. There was a mistake and this issue was unintentionally flagged as a stale pull request. The label has been removed and the issue will remain active; no action is needed on your part. Apologies for the inconvenience.

[ibocon]

Hi, @kinelski. I am interested in this issue.

I see this issue is started from your comment in PR #18491. And #18480 does not avoid using extra Get method. So Methods to test are

• CreateDataFeed
• CreateDetectionConfiguration
• CreateAlertConfiguration
• CreateHook
• AddFeedback

---

I am planning to create a mock of MetricsAdvisorAdministrationClient like below as you suggest in description,

public class MockMetricsAdvisorAdministrationClient : MetricsAdvisorAdministrationClient
{
        public virtual async Task<Response<AnomalyAlertConfiguration>> GetAlertConfiguration(string alertConfigurationId, CancellationToken cancellationToken = default)
        {
            // Throw exception when CreateAlertConfiguration call GetAlertConfiguration inside to test.
            throw;
        }
        
        // Other Get method mocks...
}

Where should I put this class in project Azure.AI.MetricsAdvisor.Tests?

---

LiveTests create MetricsAdvisorAdministrationClient instance form MetricsAdvisorLiveTestBase.GetMetricsAdvisorAdministrationClient method like below,

azure-sdk-for-net/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/tests/MetricsAdvisorAdministrationClient/AnomalyAlertConfigurationLiveTests.cs

Line 734 in 4283d09

MetricsAdvisorAdministrationClient adminClient = GetMetricsAdvisorAdministrationClient(useTokenCredential);

So, should I create new MetricsAdvisorLiveTestBase, which use MockMetricsAdvisorAdministrationClient to create a live tests?

public class MockMetricsAdvisorLiveTestBase : MetricsAdvisorLiveTestBase
{
            public override MetricsAdvisorAdministrationClient GetMetricsAdvisorAdministrationClient(bool useTokenCredential = false)
        {
            return new MockMetricsAdvisorAdministrationClient();
        }
}

Or, just create a method like in AnomalyAlertConfigurationTests?

azure-sdk-for-net/sdk/metricsadvisor/Azure.AI.MetricsAdvisor/tests/MetricsAdvisorAdministrationClient/AnomalyAlertConfigurationTests.cs

Lines 165 to 171 in 4283d09

	private MetricsAdvisorAdministrationClient GetMetricsAdvisorAdministrationClient()
	{
	var fakeEndpoint = new Uri("http://notreal.azure.com");
	var fakeCredential = new MetricsAdvisorKeyCredential("fakeSubscriptionKey", "fakeApiKey");
	return new MetricsAdvisorAdministrationClient(fakeEndpoint, fakeCredential);
	}

private MetricsAdvisorAdministrationClient GetMetricsAdvisorAdministrationClient()
{
    return new MockMetricsAdvisorAdministrationClient();
}