Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf, Stress] Handle multiple test class ctors #16971

Closed
mikeharder opened this issue Nov 14, 2020 · 1 comment
Closed

[Perf, Stress] Handle multiple test class ctors #16971

mikeharder opened this issue Nov 14, 2020 · 1 comment
Assignees
@mikeharder
Labels
Central-EngSys This issue is owned by the Engineering System team. pillar-performance The issue is related to performance, one of our core engineering pillars. pillar-reliability The issue is related to reliability, one of our core engineering pillars. (includes stress testing)

Comments

@mikeharder
Copy link
Member

The frameworks assume test classes have a single ctor which accepts the Options object. The frameworks should handle multiple ctors (as long as one matches the expected ctor), and throw a nice error if none match.

#16965 (comment)
@mikeharder mikeharder added pillar-performance The issue is related to performance, one of our core engineering pillars. pillar-reliability The issue is related to reliability, one of our core engineering pillars. (includes stress testing) Central-EngSys This issue is owned by the Engineering System team. labels Nov 14, 2020
@mikeharder mikeharder self-assigned this Nov 14, 2020
@mikeharder mikeharder mentioned this issue Nov 14, 2020
Merged
mikeharder added a commit to mikeharder/azure-sdk-for-net that referenced this issue Nov 17, 2020
@mikeharder
Improve constructor matching
a2bab47 
- Fixes Azure#16971
@mikeharder mikeharder mentioned this issue Nov 17, 2020
Closed
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this issue Dec 10, 2021
CodeGen from PR 16971 in Azure/azure-rest-api-specs
e7ca2f3 
Track2 modify readme.go.md 7 (Azure#16971)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this issue Jan 5, 2022
CodeGen from PR 16971 in Azure/azure-rest-api-specs
1cb4cd9 
Track2 modify readme.go.md 7 (Azure#16971)
@JimSuplizio
Copy link
Member

Hi @mikeharder, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@JimSuplizio JimSuplizio closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
@github-project-automation github-project-automation bot moved this from 🤔 Triage to 🎊 Closed in Azure SDK EngSys 🤖🧠 Mar 5, 2024
@Azure Azure locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikeharder mikeharder

Labels
Central-EngSys This issue is owned by the Engineering System team. pillar-performance The issue is related to performance, one of our core engineering pillars. pillar-reliability The issue is related to reliability, one of our core engineering pillars. (includes stress testing)
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Perf, Stress] Improve constructor matching mikeharder/azure-sdk-for-net
2 participants
@mikeharder @JimSuplizio