[MetricsAdvisor] Design: how Update methods should be designed #16172
Labels
blocking-release
Blocks release
Client
This issue points to a problem in the data-plane of the library.
Cognitive - Metrics Advisor
Milestone
Current approach has multiple flaws.
UpdateHook
takes ahookId
parameter and aNotificationHook
instance, which contains anId
property. Should we makeId
settable and remove the string parameter?null
andundefined
. This is likely the main cause of [MetricsAdvisor] Fix Update sample issues #16168. One of the following scenarios will happen unintentionally:null
(clear it). However, our client doesn't send anything.null
and clear it.Create
andUpdate
methods. However, some properties are immutable after creation, so they are not used during update. Also,Update
does not have required properties, so we shouldn't enforce them in the constructor (but we need to do so forCreate
).The text was updated successfully, but these errors were encountered: