Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code +. Visual Studio credential should throw Credential Unavailable Exception for adfs tenants #14639

Closed
g2vinay opened this issue Aug 28, 2020 · 0 comments · Fixed by #14763
Closed

VS Code +. Visual Studio credential should throw Credential Unavailable Exception for adfs tenants #14639

g2vinay opened this issue Aug 28, 2020 · 0 comments · Fixed by #14763
Assignees
@schaabs
Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Milestone
[2020] September

Comments

@g2vinay
Copy link
Member

g2vinay commented Aug 28, 2020

VS Code and Visual Studio IDE do not support ADFS authorities
Their respective credentials should throw Credential Unavailable Exception to avoid breaking DAC auth flow.

Throw CredentialUnavailableException is if supplied tenant id equals adfs;

Verify Sovereign cloud support for Visual Studio Azure Plugin/Extension.
Does it accept authority host/ URL from user settings ?
@g2vinay g2vinay added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Aug 28, 2020
@g2vinay g2vinay added this to the [2020] September milestone Aug 28, 2020
@g2vinay g2vinay added the blocking-release Blocks release label Aug 29, 2020
@schaabs schaabs mentioned this issue Sep 1, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@schaabs schaabs

Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2020] September
2 participants
@g2vinay @schaabs