Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KeyVault] Make RBAC models mutable to support full CRUD for RoleDefinitions #12702

Closed
christothes opened this issue Jun 10, 2020 · 0 comments · Fixed by #14314
Closed

[KeyVault] Make RBAC models mutable to support full CRUD for RoleDefinitions #12702

christothes opened this issue Jun 10, 2020 · 0 comments · Fixed by #14314
Assignees
@christothes
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2020] September

Comments

@christothes
Copy link
Member

christothes commented Jun 10, 2020 •
edited
Loading

This may be automatically resolved if the service decides to implement full CRUD - the generator will make the types mutable once the change makes it to the swagger.

If not we may do this proactively in anticipation of that change and to support generalization of RBAC.

update: Upcoming generator changes may address this also.
@christothes christothes added KeyVault Client This issue points to a problem in the data-plane of the library. labels Jun 10, 2020
@christothes christothes added this to the [2020] July milestone Jun 10, 2020
@christothes christothes self-assigned this Jun 10, 2020
@christothes christothes mentioned this issue Jun 10, 2020
Merged
@christothes christothes changed the title [KeyVault] Make RBAC models immutable to support full CRUD for RoleDefinitions [KeyVault] Make RBAC models mutable to support full CRUD for RoleDefinitions Jun 25, 2020
@heaths heaths modified the milestones: [2020] August, [2020] September Jul 8, 2020
@christothes christothes added the blocking-release Blocks release label Aug 18, 2020
@christothes christothes mentioned this issue Aug 18, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christothes christothes

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2020] September
Development

Successfully merging a pull request may close this issue.

Make RoleDefinitions mutable christothes/azure-sdk-for-net
2 participants
@christothes @heaths