Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pending service change] Change CopyAuthorization.ExpiresOn from long to DateTimeOffset #12181

Closed
maririos opened this issue May 19, 2020 · 2 comments · Fixed by #12770
Closed

[Pending service change] Change CopyAuthorization.ExpiresOn from long to DateTimeOffset #12181

maririos opened this issue May 19, 2020 · 2 comments · Fixed by #12770
Assignees
@maririos
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer Cognitive Services
Milestone
[2020] July

Comments

@maririos
Copy link
Member

The service currently has a bug where the return value can't be parsed into a DateTimeOffset.
Once they fixed it, we need to update our type from long -> DateTimeOffset
@maririos maririos added Client This issue points to a problem in the data-plane of the library. Cognitive Services FormRecognizer labels May 19, 2020
@maririos maririos added this to the Backlog milestone May 19, 2020
@maririos maririos mentioned this issue May 19, 2020
Merged
@annelo-msft annelo-msft modified the milestones: Backlog, [2020] July Jun 2, 2020
@annelo-msft annelo-msft added the blocking-release Blocks release label Jun 4, 2020
@annelo-msft
Copy link
Member

@maririos, do we know if they will fix this before code complete for this preview? If not, we need to decide if this is a release-blocker.

@mayurid

@maririos
Copy link
Member Author

maririos commented Jun 4, 2020

Chris commit to make this fix available for GA.
There is a fix in Canary, but it brought up another bug, so it is still failing.

I communicated this with KC and Ted when doing the Copy API design and they are ok with us having it as is for Previews and definitely change it for GA, so I don't consider this a blocker

@annelo-msft annelo-msft changed the title Change CopyAuthorization.ExpiresOn from long to DateTimeOffset [Pending service change] Change CopyAuthorization.ExpiresOn from long to DateTimeOffset Jun 4, 2020
@maririos maririos self-assigned this Jun 13, 2020
@maririos maririos mentioned this issue Jun 15, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maririos maririos

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer Cognitive Services
Projects
None yet
Milestone
[2020] July
Development

Successfully merging a pull request may close this issue.

[FR] Updates on Copy API maririos/azure-sdk-for-net
2 participants
@maririos @annelo-msft