Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search model renames #12150

Closed
heaths opened this issue May 18, 2020 · 0 comments · Fixed by #12302
Closed

Search model renames #12150

heaths opened this issue May 18, 2020 · 0 comments · Fixed by #12302
Assignees
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Search
Milestone

Comments

@heaths
Copy link
Member

heaths commented May 18, 2020

There are a few more renames to make. But not just renames: the "V2" models should be collapsed with their v1 (no suffix, that is) counterparts and original @odata.type retained for round-tripping. When new ones are created, the "V2" equivalent should always be created because the v1s will cause the service to fail when using the new api-version.

Old name New name Notes
EdgeNGramTokenFilterV2 EdgeNGramTokenFilter Collapse with existing EdgeNGramTokenFilter
KeywordTokenizerV2 KeywordTokenizer Collapse with existing KeywordTokenizer (will have separate properties for v1 and "V2")
LuceneStandardTokenizerV2 LuceneStandardTokenizer Collapse with existing LucenseStandardTokenizer
NGramTokenFilterV2 NGramTokenFilter Collapse with existing NGramTokenFilter
PathHierarchyTokenizerV2 PathHierarchyTokenizer (There is no v1)
Similarity SimilarityAlgorithm Do not rename derivative types
Suggester SearchSuggester
@heaths heaths added blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Search labels May 18, 2020
@heaths heaths added this to the [2020] June milestone May 18, 2020
@heaths heaths self-assigned this May 18, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant