Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FormRecognizer] Tests: FormTrainingClient live tests not deleting trained models #12140

Closed
kinelski opened this issue May 18, 2020 · 2 comments · Fixed by #38339
Closed

[FormRecognizer] Tests: FormTrainingClient live tests not deleting trained models #12140

kinelski opened this issue May 18, 2020 · 2 comments · Fixed by #38339
Assignees
@kinelski
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer Cognitive Services test-reliability Issue that causes tests to be unreliable
Milestone
Backlog

Comments

@kinelski
Copy link
Member

kinelski commented May 18, 2020 •
edited
Loading

Description

Tests in FormTrainingClientLiveTests are not deleting the models trained for testing upon completion. The DisposableTrainedModel class is used for this purpose in FormRecognizerClientLiveTests.

Edit: some tests in OperationsLiveTests have the same issue.

Should we do the same in the FormTrainingClient live tests? Or would it be better to NOT wrap the StartTraining call in a separate class, making it an explicit call and relying on try/finally blocks to delete the models? The later would make sense in methods whose sole objective is testing the StartTraining method, while the former would be used in methods where training is only one of the steps of the test.
@kinelski kinelski added Test Debt Cognitive Services Client This issue points to a problem in the data-plane of the library. labels May 18, 2020
@kinelski kinelski added this to the Backlog milestone May 18, 2020
@kinelski kinelski self-assigned this May 18, 2020
@AlexGhiondea AlexGhiondea modified the milestones: Backlog, [2020] July Jun 3, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this issue Dec 17, 2020
CodeGen from PR 12140 in Azure/azure-rest-api-specs
233df08 
add subscription track2 config (Azure#12140)
@kinelski kinelski modified the milestones: MQ-2020, Backlog Jan 6, 2021
@jsquire jsquire added test-reliability Issue that causes tests to be unreliable and removed Test Debt labels Jul 16, 2021
@pallavit
Copy link
Contributor

@kinelski is this still valid, can it be closed?

@kinelski
Copy link
Member Author

@kinelski is this still valid, can it be closed?

It's still valid.

kinelski added a commit to kinelski/azure-sdk-for-net that referenced this issue Aug 23, 2023
@kinelski
Fixing Azure#12140
89b8527
@kinelski kinelski mentioned this issue Aug 23, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kinelski kinelski

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer Cognitive Services test-reliability Issue that causes tests to be unreliable
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

[FormRecognizer] Fixing a couple of minor issues kinelski/azure-sdk-for-net
6 participants
@jsquire @kinelski @AlexGhiondea @maririos @pallavit @annelo-msft