Always set otel.status_code (#22115)

Azure · Jun 23, 2021 · be4174d · be4174d
1 parent 50c62cc
commit be4174d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/sdk/core/Azure.Core/src/Pipeline/Internal/RequestActivityPolicy.cs b/sdk/core/Azure.Core/src/Pipeline/Internal/RequestActivityPolicy.cs
@@ -94,6 +94,11 @@ private async ValueTask ProcessAsync(HttpMessage message, ReadOnlyMemory<HttpPip
                 {
                     activity.AddTag("otel.status_code", "ERROR");
                 }
+                else
+                {
+                    // Set the status to UNSET so the AppInsights doesn't try to infer it from the status code
+                    activity.AddTag("otel.status_code", "UNSET");
+                }
             }
             finally
             {

diff --git a/sdk/core/Azure.Core/tests/RequestActivityPolicyTests.cs b/sdk/core/Azure.Core/tests/RequestActivityPolicyTests.cs
@@ -61,9 +61,9 @@ public async Task ActivityIsCreatedForRequest()
             CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("http.user_agent", "agent"));
             CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("requestId", clientRequestId));
             CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("serviceRequestId", "server request id"));
+            CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("otel.status_code", "UNSET"));
             CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("kind", "client"));
             CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("az.namespace", "Microsoft.Azure.Core.Cool.Tests"));
-            CollectionAssert.DoesNotContain(activity.Tags.Select(t=>t.Key), "otel.status_code");
         }
 
         [Test]
-Original file line number
+Diff line change
@@ Expand Up @@
                     {
                         activity.AddTag("otel.status_code", "ERROR");
                     }
+                    else
+                    {
+                        // Set the status to UNSET so the AppInsights doesn't try to infer it from the status code
+                        activity.AddTag("otel.status_code", "UNSET");
+                    }
                 }
                 finally
                 {
@@ Expand Down @@