[FormRecognizer] Rename for cross-language API consistency #8808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `beginRecognizeForms` => `beginRecognizeCustomForms`
export `Model` from model.ts instead of from generated code.
|
Part of #8610 |
|
/azp run js - formrecognizer - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The failing live tests should be passing after we merge #8749 as we will no longer passing the charset part. |
16 tasks
willmtemple
approved these changes
May 14, 2020
maririos
reviewed
May 15, 2020
| /** | ||
| * Status of the model. | ||
| */ | ||
| status: ModelStatus; |
There was a problem hiding this comment.
Other languages are calling the type CustomFormModelStatus instead of `ModelStatus
There was a problem hiding this comment.
Good catch! Updated. Thanks for reviewing!
maririos
approved these changes
May 15, 2020
TrainStatus => TrainingStatus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.