Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyVault] Regenerate @azure/keyvault to address customer issues #6187

Conversation

daviwil
Copy link
Contributor

@daviwil daviwil commented Nov 13, 2019

This change regenerates the @azure/keyvault library using autorest.typescript 4.2.3 so that it picks up ms-rest-js 2.0. This change is needed to alleviate some customer reported issues with that library. We'll also be deprecating this library after the hotfix update.

Tasks

@daviwil
Copy link
Contributor Author

daviwil commented Nov 13, 2019

This hotfix may not actually be necessary:

I think we should hold off on merging this PR and shipping the hotfix until we determine that it's necessary.

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need a message on the top of the readme talking about the deprecation and pointer to the new libraries.

Go ahead and merge the PR. Will share the wording for the message and we can do that in a separate PR

@ramya-rao-a
Copy link
Contributor

The @azure/keyvault package has been officially deprecated with relevant deprecation message. We also don't have the package as part of this repo anymore. Therefore, this PR is no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants