[KeyVault] dotenv fix #4533
Merged
[KeyVault] dotenv fix #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, we can have a `.env` file in `sdk/keyvault` (the parent folder, as well as with other of our projects using dotenv) with the following properties: ``` AZURE_CLIENT_ID=XXXXXXXX AZURE_CLIENT_SECRET=XXXXXXXX AZURE_TENANT_ID=XXXXXXXX KEYVAULT_NAME=XXXXXXXX TEST_MODE=["record" or "playback", without quotes] ``` And then run `rushx integration-test:node` to record (or playback) all the tests with the Node environment, and also `rushx integration-test:browser` to run the tests with the browser environment. Would this help with Azure#4389 ? Please review 💙
|
This will work in the root directory of both projects. The main issue that this solves is that, once rollup was added, the path changed since the output file is now located elsewhere. This output file is not expected to change locations anytime soon, so we won't need to change it in the foreseeable future. |
sophiajt
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we can have a
.envfile insdk/keyvault(the parentfolder, as well as with other of our projects using dotenv) with the
following properties:
And then run
rushx integration-test:nodeto record (or playback) allthe tests with the Node environment, and also
rushx integration-test:browserto run the tests with the browser environment.
Would this help with #4389 ?
Note: The recorder already replaces all the environment variables with stub values! Only TEST_MODE=playback is needed to run the playback tests.
Please review 💙