Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR] @azure/arm-apimanagement #4495

Closed

Conversation

openapi-sdkautomation[bot]
Copy link
Contributor

Created to accumulate changes for: @azure/arm-apimanagement

@ramya-rao-a
Copy link
Contributor

Please re-generate using the older generator.
This PR is using the new core packages

@ramya-rao-a ramya-rao-a removed their request for review July 29, 2019 20:20
ramya-rao-a and others added 12 commits July 29, 2019 13:21
- Dependency was accidentally added with a `~` instead of `^`
…ition (#4467)

* [EPH] Call methods on PartitionProcessor while processing single partition
…ntication (#4404)

* Add UsernamePasswordCredential for username/password authentication

* Enforce https for IdentityClient's authorityHost option

* Make sure https actually ends with a ':'
With this change, we can have a `.env` file in `sdk/keyvault` (the parent
folder, as well as with other of our projects using dotenv) with the
following properties:

```
AZURE_CLIENT_ID=XXXXXXXX
AZURE_CLIENT_SECRET=XXXXXXXX
AZURE_TENANT_ID=XXXXXXXX
KEYVAULT_NAME=XXXXXXXX
TEST_MODE=["record" or "playback", without quotes]
```

And then run `rushx integration-test:node` to record (or playback) all
the tests with the Node environment, and also `rushx integration-test:browser`
to run the tests with the browser environment.

Would this help with #4389 ?

Please review 💙
fix: apimanagment model validation

- Add missing "body" in response
Didn't add "body" for some "202" with no schemas, but maybe they should be empty.
@openapi-sdkautomation openapi-sdkautomation bot requested a review from chradek as a code owner July 30, 2019 21:51
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleas re-generate such that the PR contains only files relevant to api management

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants