Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR] @azure/arm-subscriptions #4480

Closed

Conversation

openapi-sdkautomation[bot]
Copy link
Contributor

Created to accumulate changes for: @azure/arm-subscriptions

@openapi-sdkautomation openapi-sdkautomation bot requested a review from daviwil as a code owner July 29, 2019 18:20
@ramya-rao-a
Copy link
Contributor

2 pieces of feedback here

  • Shouldn't we be using major version 2 for the ms-rest-* libraries?
  • There are some file changes in this PR that are outside of the subscriptions folder. This must be due to some merge conflicts. Can somebody take a look at this?

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please regenerate the PR such that it only has changes to arm-subscriptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants