Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CryptographyClient] WIP Implementation #4432

Closed
wants to merge 1 commit into from

Conversation

sadasant
Copy link
Contributor

Based on: #4415

If merged,
fixes #4415

Current questions:

  • How do we distinguish between doing a service call or encrypting locally?
    • If the key is a string, is that enough to assume we'll use the remote service?
    • Otherwise, should we always try to get the key in order to determine whether we'll do the operation locally or not?
  • Does the current KeyVault client has a way of extracting the Key Name and version from the Key's URL?
  • Does the current KeyVault client has a way of extracting the version of a Key from the Key's URL?
  • If we receive a JWK object as the Key, is there a way to derive the remote key? Should we create a new temporary key?

@sadasant sadasant added the Client This issue points to a problem in the data-plane of the library. label Jul 25, 2019
@sadasant sadasant requested review from sophiajt and schaabs July 25, 2019 22:04
@sadasant sadasant self-assigned this Jul 25, 2019
@sadasant
Copy link
Contributor Author

Closing in favor of a draft PR

@sadasant sadasant closed this Jul 25, 2019
@sadasant
Copy link
Contributor Author

Here's the draft PR: #4434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CryptographyClient support
1 participant