Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defender easm sdk #27256

Merged
merged 17 commits into from
Oct 16, 2023
Merged

Add defender easm sdk #27256

merged 17 commits into from
Oct 16, 2023

Conversation

thang-bit
Copy link
Member

@thang-bit thang-bit commented Sep 26, 2023

product documentation
Azure/azure-sdk#5062
Typespec PR: Azure/azure-rest-api-specs#24937
arcboard: Azure/azure-sdk#5062
apiview: https://apiview.dev/Assemblies/Review/03ef0c5f65374c3789d8302ef5c9c570

Packages impacted by this PR

Issues associated with this PR

Azure SDK Review issue: https://github.com/Azure/azure-sdk-pr/issues/1276
Azure SDK Introducing issue: Azure/azure-sdk#5062

Describe the problem that is addressed by this PR

Adding a new JavaScript data-plane sdk for EASM service

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Yes, test cases are added

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Used npx tsp complile to generate the PR

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@thang-bit
Copy link
Member Author

@xirzec, I have moved PR: #26755 to this PR

@thang-bit
Copy link
Member Author

thang-bit commented Oct 2, 2023

Hi Team, can someone review this PR whenever they have time?

API view: https://apiview.dev/Assemblies/Review/03ef0c5f65374c3789d8302ef5c9c570

This is the link to the review meeting: https://microsoft-my.sharepoint.com/:v:/p/teglaza/Ecjz9icYN6VPgF2ggPn3YEIBOXcWkxKGMQuvSPwHpc4nxg

cc: @joheredi @xirzec

Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.

We shouldn't be adding recordings into this repo, and should use the latest workflow instead, unless there's anything I am missing about rest clients.

https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/test-utils/recorder/ASSET_SYNC_MIGRATION.md

SUBSCRIPTIONID to SUBSCRIPTION_ID to readability
Update README, so the sample links point to future actual link
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than two more nit comments

…into easm-js-sdk

Resolve merge conflict
Update environments names in samples files
@thang-bit
Copy link
Member Author

@jeremymeng would this PR be merged automatically? Or will it be manually merged by the reviewers

@jeremymeng jeremymeng merged commit b00a93b into Azure:main Oct 16, 2023
@jeremymeng
Copy link
Member

@thang-bit as a maintainer you should request write permission per instruction here https://eng.ms/docs/products/azure-developer-experience/onboard/access?tabs=write-access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants