Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary jobMatrixFilter variable #24836

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Conversation

weshaggard
Copy link
Member

Remove unnecessary old variable that currently breaks the pipeline after @kurtzeborn change #23941.

jobMatrixFilter variables are no longer applicable
@weshaggard weshaggard requested a review from joheredi as a code owner February 11, 2023 00:23
@ghost ghost added the Tables label Feb 11, 2023
@weshaggard
Copy link
Member Author

/azp run js - data-tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@joheredi joheredi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added this when node8 was still being tested. Removing this should be safe now

@jeremymeng jeremymeng merged commit 193194d into main Feb 13, 2023
@jeremymeng jeremymeng deleted the weshaggard-patch-1 branch February 13, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants