Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Correct the file path for type declaration in @azure-rest/maps-search #24624

Merged

Conversation

andykao1213
Copy link
Member

@andykao1213 andykao1213 commented Jan 31, 2023

Packages impacted by this PR

  • @azure-rest/maps-search

Issues associated with this PR

Describe the problem that is addressed by this PR

  • The type declaration file path is incorrect in the files prop in package.json, thus causing the user cannot access the file.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@andykao1213 andykao1213 requested a review from dubiety January 31, 2023 03:02
@andykao1213 andykao1213 marked this pull request as ready for review January 31, 2023 03:02
@andykao1213 andykao1213 requested a review from xirzec as a code owner January 31, 2023 03:02
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@andykao1213 andykao1213 merged commit 2dd6fe7 into Azure:main Feb 1, 2023
@andykao1213 andykao1213 deleted the maps/fix-type-path-for-search-rest branch February 1, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants