Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Uncomment the link in README for render, search, geolocation #24610

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

andykao1213
Copy link
Member

Packages impacted by this PR

  • @azure-rest/maps-search
  • @azure-rest/maps-geolocation
  • @azure-rest/maps-render

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@andykao1213 andykao1213 requested a review from dubiety January 30, 2023 05:44
@andykao1213 andykao1213 self-assigned this Jan 30, 2023
@andykao1213
Copy link
Member Author

The API Reference link for @ azure-rest/maps-search has yet to be available. I'm working with the documentation team. The PR will be ready for review after the document is ready.

@andykao1213
Copy link
Member Author

It turns out that there's an issue in the @azure-rest/maps-search that failed the document's pipeline. The fix is addressed in #24624. This PR will be ready once we release @azure-rest/maps-search @ 1.0.0-beta-2

@andykao1213 andykao1213 marked this pull request as ready for review February 14, 2023 09:17
@andykao1213 andykao1213 requested a review from xirzec as a code owner February 14, 2023 09:17
@andykao1213 andykao1213 enabled auto-merge (squash) February 14, 2023 09:17
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@andykao1213 andykao1213 merged commit 2d467a2 into Azure:main Feb 14, 2023
@andykao1213 andykao1213 deleted the maps/fix-issued-link branch February 14, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants