New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[identity] Added support for disabling authority validation and instance discovery #24070

Merged

KarishmaGhiya merged 25 commits into Azure:main from KarishmaGhiya:authority-validate

Feb 10, 2023

Member

KarishmaGhiya commented Dec 1, 2022 •

edited

Loading

Packages impacted by this PR

@azure/identity

Issues associated with this PR

Describe the problem that is addressed by this PR

Added support for disabling authority validation and instance discovery

Checklists

Added impacted package name to the issue description
Added a changelog (if necessary)

KarishmaGhiya requested review from witemple-msft and schaabs as code owners

December 1, 2022 00:01

ghost added the Azure.Identity label

KarishmaGhiya requested a review from mpodwysocki

December 1, 2022 02:44

KarishmaGhiya changed the title ~~[identity] expose authority validation options through confidential credentials~~ [identity] expose authority validation options through credentials

mpodwysocki reviewed

View reviewed changes

sdk/identity/identity/src/credentials/authorityValidationOptions.ts Outdated Show resolved Hide resolved

mpodwysocki reviewed

View reviewed changes

sdk/identity/identity/src/credentials/authorityValidationOptions.ts Outdated Show resolved Hide resolved

mpodwysocki reviewed

View reviewed changes

sdk/identity/identity/src/msal/utils.ts Outdated Show resolved Hide resolved

mpodwysocki reviewed

View reviewed changes

sdk/identity/identity/src/msal/utils.ts Outdated Show resolved Hide resolved

mpodwysocki reviewed

View reviewed changes

sdk/identity/identity/src/msal/flows.ts Outdated Show resolved Hide resolved

mpodwysocki reviewed

View reviewed changes

sdk/identity/identity/src/msal/nodeFlows/msalNodeCommon.ts Outdated Show resolved Hide resolved

mpodwysocki reviewed

View reviewed changes

sdk/identity/identity/src/msal/browserFlows/msalBrowserCommon.ts Outdated Show resolved Hide resolved

KarishmaGhiya requested review from bterlson, xirzec and jeremymeng as code owners

December 1, 2022 03:21

Collaborator

azure-sdk commented Dec 1, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

bgavrilMS reviewed

View reviewed changes

sdk/identity/identity/review/identity.api.md Show resolved Hide resolved

bgavrilMS reviewed

View reviewed changes

sdk/identity/identity/src/msal/utils.ts Outdated Show resolved Hide resolved

bgavrilMS reviewed

View reviewed changes

sdk/identity/identity/review/identity.api.md Outdated Show resolved Hide resolved

Member Author

KarishmaGhiya commented Dec 8, 2022

The correct solution - expose an "instance discovery" boolean from SDK should - this flag should disable authority validation and also disable instance discovery for MSAL

bgavrilMS reviewed

View reviewed changes

sdk/identity/identity/review/identity.api.md Show resolved Hide resolved

bgavrilMS reviewed

View reviewed changes

sdk/identity/identity/src/msal/utils.ts Outdated Show resolved Hide resolved

bgavrilMS reviewed

View reviewed changes

sdk/identity/identity/src/msal/nodeFlows/msalNodeCommon.ts Outdated Show resolved Hide resolved

KarishmaGhiya requested review from hectorhdzg and JacksonWeber as code owners

January 19, 2023 22:46

KarishmaGhiya force-pushed the authority-validate branch from e7907e2 to b0fcbac Compare

February 8, 2023 20:36

mpodwysocki reviewed

View reviewed changes

sdk/identity/identity/src/msal/browserFlows/msalBrowserCommon.ts Outdated Show resolved Hide resolved

mpodwysocki reviewed

View reviewed changes

sdk/identity/identity/src/credentials/authorityValidationOptions.ts Outdated Show resolved Hide resolved

mpodwysocki reviewed

View reviewed changes

sdk/identity/identity/review/identity.api.md Outdated Show resolved Hide resolved


          expose authority validation options through confidential credentials

09054d2

KarishmaGhiya added 11 commits

February 9, 2023 19:10


          update api

4f3e397


          authority validation

3d67162


          update api

fc556ff


          update changes

d3447be


          update code

c22ce97


          identity

215124c


          undo recording changes

cc59ae6


          do i need this

1d44705


          update the authority validation

dee0c37


          update tests

147adc1


          lint and formatting

a5645af

KarishmaGhiya force-pushed the authority-validate branch from 84f953c to a5645af Compare

February 10, 2023 03:11

KarishmaGhiya added 4 commits

February 9, 2023 19:16


          rename the api

d980a96


          update the formatting

f133d57


          api view updates

e425b2b


          update the api

4d149f6

KarishmaGhiya changed the title ~~[identity] expose authority validation options through credentials~~ [identity] Added support for disabling authority validation and instance discovery

KarishmaGhiya added 2 commits

February 9, 2023 19:47


          update the package version

20f9e52


          something to help

0abb48d

KarishmaGhiya commented

View reviewed changes

sdk/identity/identity/CHANGELOG.md Show resolved Hide resolved


          Update sdk/identity/identity/CHANGELOG.md

32f3530

scottaddie reviewed

View reviewed changes

sdk/identity/identity/CHANGELOG.md Outdated Show resolved Hide resolved

HarshaNalluru reviewed

View reviewed changes

sdk/identity/identity/test/msalTestUtils.ts Outdated Show resolved Hide resolved

KarishmaGhiya and others added 3 commits

February 10, 2023 11:32


          Update sdk/identity/identity/CHANGELOG.md

cb368ee

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>


          fix the recordings replacement

90e1c1d


          Merge branch 'authority-validate' of https://github.com/KarishmaGhiya…

7a6d1c6

…/azure-sdk-for-js into authority-validate

mpodwysocki approved these changes

View reviewed changes

Member

mpodwysocki left a comment

LGTM

KarishmaGhiya enabled auto-merge (squash)

February 10, 2023 20:19

KarishmaGhiya merged commit cf4ab7a into Azure:main

mpodwysocki deleted the authority-validate branch

February 11, 2023 19:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

HarshaNalluru HarshaNalluru left review comments

scottaddie scottaddie left review comments

bgavrilMS bgavrilMS left review comments

mpodwysocki mpodwysocki approved these changes

witemple-msft Awaiting requested review from witemple-msft

schaabs Awaiting requested review from schaabs schaabs is a code owner

bterlson Awaiting requested review from bterlson bterlson is a code owner

xirzec Awaiting requested review from xirzec

jeremymeng Awaiting requested review from jeremymeng

hectorhdzg Awaiting requested review from hectorhdzg

JacksonWeber Awaiting requested review from JacksonWeber

Labels