[dev-tool] Fix eslint errors and re-enable linter in dev-tool #18853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
reviewed
Nov 29, 2021
| @@ -20,7 +22,7 @@ export const commandInfo = makeCommandInfo( | |||
| ); | |||
|
|
|||
| const prettierOptions: prettier.Options = { | |||
| ...(require("../../../../eslint-plugin-azure-sdk/prettier.json") as prettier.Options), | |||
| ...(defaultPrettierOptions as prettier.Options), | |||
There was a problem hiding this comment.
I do not think this will work. I believe we need the dynamic behavior of require. /cc @witemple-msft
deyaaeldeen
reviewed
Nov 29, 2021
Comment on lines
+30
to
+35
| /* eslint-disable @typescript-eslint/no-empty-function */ | ||
| error: () => {}, | ||
| warn: () => {}, | ||
| info: () => {}, | ||
| log: () => {} | ||
| /* eslint-enable @typescript-eslint/no-empty-function */ |
There was a problem hiding this comment.
NIT:
Suggested change
| /* eslint-disable @typescript-eslint/no-empty-function */ | |
| error: () => {}, | |
| warn: () => {}, | |
| info: () => {}, | |
| log: () => {} | |
| /* eslint-enable @typescript-eslint/no-empty-function */ | |
| error: () => { /** empty body */ }, | |
| warn: () => { /** empty body */ }, | |
| info: () => { /** empty body */ }, | |
| log: () => { /** empty body */ } |
deyaaeldeen
reviewed
Nov 29, 2021
|
FYI There is an overlap between this PR and #18819. /cc @jeremymeng @ramya-rao-a |
|
Oh gosh, I totally missed that PR, my bad 🤦🏻. Classic. I'll close this one and we can work off the one that's already open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of work for #17826.