Ensuring that the build script also cleans #17123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c804fa8 to
d3a6e15
Compare
xirzec
reviewed
Aug 25, 2021
| @@ -31,7 +31,7 @@ | |||
| "audit": "node ../../../common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit", | |||
| "build:samples": "echo skipped", | |||
| "build:test": "tsc -p . && rollup -c 2>&1", | |||
| "build": "npm run extract-api && tsc -p . && rollup -c 2>&1", | |||
| "build": "npm run clean && npm run extract-api && tsc -p . && rollup -c 2>&1", | |||
There was a problem hiding this comment.
we should remove prebuild if we do this, since otherwise it'll duplicate when running the task directly.
|
Hello @sadasant! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@sadasant thank you so much for having the energy to do this change. I didn't have it in me yesterday to attempt, but you have delivered. 👍 |
|
@xirzec that is too kind, Jeff. Thank you. I needed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought
rush buildcalled prebuild! 😮