fix eslint errors for search packages

sdk/search/search-documents/review/search-documents.api.md

@@ -410,6 +410,9 @@ export type GetIndexOptions = OperationOptions;
 // @public
 export type GetIndexStatisticsOptions = OperationOptions;
 
+// @public
+export type getSearchClientOptions = SearchIndexClientOptions;
+
 // @public
 export type GetServiceStatisticsOptions = OperationOptions;
 
@@ -1108,7 +1111,7 @@ export class SearchIndexClient {
     readonly endpoint: string;
     getIndex(indexName: string, options?: GetIndexOptions): Promise<SearchIndex>;
     getIndexStatistics(indexName: string, options?: GetIndexStatisticsOptions): Promise<SearchIndexStatistics>;
-    getSearchClient<T>(indexName: string, options?: SearchClientOptions): SearchClient<T>;
+    getSearchClient<T>(indexName: string, options?: getSearchClientOptions): SearchClient<T>;
     getServiceStatistics(options?: GetServiceStatisticsOptions): Promise<SearchServiceStatistics>;
     getSynonymMap(synonymMapName: string, options?: GetSynonymMapsOptions): Promise<SynonymMap>;
     listIndexes(options?: ListIndexesOptions): IndexIterator;

sdk/search/search-documents/src/index.ts

@@ -13,6 +13,7 @@ export {
   CountDocumentsOptions,
   DeleteDocumentsOptions,
   GetDocumentOptions,
+  getSearchClientOptions,
   IndexDocumentsAction,
   ListSearchResultsPageSettings,
   IndexDocumentsOptions,

sdk/search/search-documents/src/indexModels.ts

@@ -11,6 +11,7 @@ import {
   ScoringStatistics
 } from "./generated/data/models";
 import { PagedAsyncIterableIterator } from "@azure/core-paging";
+import { SearchIndexClientOptions } from "./searchIndexClient";
 
 /**
  * Options for performing the count operation on the index.
@@ -60,6 +61,10 @@ export type SearchIndexingBufferedSenderDeleteDocumentsOptions = OperationOption
  */
 export type SearchIndexingBufferedSenderFlushDocumentsOptions = OperationOptions;
 
+/**
+ * Alias of Search Index Client Options parameter to satisfy linting constraints
+ */
+export type getSearchClientOptions = SearchIndexClientOptions;
 /**
  * Options for retrieving a single document.
  */

sdk/search/search-documents/src/searchIndexClient.ts

@@ -37,10 +37,11 @@ import {
   SearchIndexStatistics,
   SearchServiceStatistics
 } from "./serviceModels";
+import { getSearchClientOptions } from "./indexModels";
 import * as utils from "./serviceUtils";
 import { createSpan } from "./tracing";
 import { odataMetadataPolicy } from "./odataMetadataPolicy";
-import { SearchClient, SearchClientOptions } from "./searchClient";
+import { SearchClient } from "./searchClient";
 
 /**
  * Client options used to configure Cognitive Search API requests.
@@ -611,7 +612,7 @@ export class SearchIndexClient {
    * @param indexName Name of the index
    * @param options SearchClient Options
    */
-  public getSearchClient<T>(indexName: string, options?: SearchClientOptions): SearchClient<T> {
+  public getSearchClient<T>(indexName: string, options?: getSearchClientOptions): SearchClient<T> {
     return new SearchClient<T>(this.endpoint, indexName, this.credential, options || this.options);
   }
 }

sdk/search/search-documents/src/searchIndexingBufferedSender.ts

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
 import {
   IndexDocumentsAction,
   SearchIndexingBufferedSenderUploadDocumentsOptions,

sdk/search/search-documents/src/searchIndexingBufferedSenderImpl.ts

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
 import { SearchClient } from "./searchClient";
 import { IndexDocumentsBatch } from "./indexDocumentsBatch";
 import {
@@ -78,7 +81,8 @@ class SearchIndexingBufferedSenderImpl<T> implements SearchIndexingBufferedSende
     this.batchObject = new IndexDocumentsBatch<T>();
     if (this.autoFlush) {
       const interval = setInterval(() => this.flush(), this.flushWindowInMs);
-      interval?.unref();
+      const unblock = interval?.unref;
+      unblock();
       this.cleanupTimer = () => {
         clearInterval(interval);
       };
@@ -244,7 +248,9 @@ class SearchIndexingBufferedSenderImpl<T> implements SearchIndexingBufferedSende
     if (this.batchObject.actions.length > 0) {
       await this.internalFlush(true);
     }
-    this.cleanupTimer && this.cleanupTimer();
+    if (this.cleanupTimer) {
+      this.cleanupTimer();
+    }
   }
 
   /**

sdk/search/search-documents/src/serviceUtils.ts

@@ -283,7 +283,7 @@ export function convertSimilarityToPublic(
     return similarity;
   }
 
-  if (similarity.odatatype == "#Microsoft.Azure.Search.ClassicSimilarity") {
+  if (similarity.odatatype === "#Microsoft.Azure.Search.ClassicSimilarity") {
     return similarity as ClassicSimilarity;
   } else {
     return similarity as BM25Similarity;
@@ -370,7 +370,9 @@ export function generatedIndexToPublicIndex(generatedIndex: GeneratedSearchIndex
   };
 }
 
-export function generatedSearchResultToPublicSearchResult<T>(results: GeneratedSearchResult[]) {
+export function generatedSearchResultToPublicSearchResult<T>(
+  results: GeneratedSearchResult[]
+): SearchResult<T>[] {
   const returnValues: SearchResult<T>[] = results.map<SearchResult<T>>((result) => {
     const { _score, _highlights, ...restProps } = result;
     const doc: { [key: string]: any } = {

sdk/search/search-documents/test/node/searchClient.spec.ts

@@ -62,7 +62,7 @@ describe("SearchClient", function() {
 
   it("autocomplete returns zero results for invalid query", async function() {
     const autoCompleteResult: AutocompleteResult = await searchClient.autocomplete("garbxyz", "sg");
-    assert.isTrue(autoCompleteResult.results.length == 0);
+    assert.isTrue(autoCompleteResult.results.length === 0);
   });
 
   it("search returns the correct search result", async function() {

sdk/search/search-documents/test/node/searchIndexClient.spec.ts

@@ -99,8 +99,6 @@ describe("SearchIndexClient", function() {
         ];
         assert.include(synonyms, synonymMap.synonyms[0]);
         assert.include(synonyms, synonymMap.synonyms[1]);
-      } catch (ex) {
-        throw ex;
       } finally {
         await indexClient.deleteSynonymMap(synonymMap);
       }
@@ -207,8 +205,6 @@ describe("SearchIndexClient", function() {
         index = await indexClient.getIndex(indexName);
         assert.equal(index.name, indexName);
         assert.equal(index.fields.length, 5);
-      } catch (ex) {
-        throw ex;
       } finally {
         await indexClient.deleteIndex(index);
       }

sdk/search/search-documents/test/node/searchIndexerClient.spec.ts

@@ -109,8 +109,6 @@ describe("SearchIndexerClient", function() {
         assert.equal(indexer.dataSourceName, "my-data-source-1");
         assert.equal(indexer.targetIndexName, TEST_INDEX_NAME);
         assert.isFalse(indexer.isDisabled);
-      } catch (ex) {
-        throw ex;
       } finally {
         await indexerClient.deleteIndexer(indexer);
       }
@@ -178,8 +176,6 @@ describe("SearchIndexerClient", function() {
         assert.equal(dataSourceConnection.name, "my-data-source-3");
         assert.equal(dataSourceConnection.type, "cosmosdb");
         assert.equal(dataSourceConnection.container.name, "hotels");
-      } catch (ex) {
-        throw ex;
       } finally {
         await indexerClient.deleteDataSourceConnection(dataSourceConnection);
       }
@@ -267,8 +263,6 @@ describe("SearchIndexerClient", function() {
         assert.equal(skillSet.skills.length, 1);
         assert.equal(skillSet.skills[0].inputs.length, 2);
         assert.equal(skillSet.skills[0].outputs.length, 3);
-      } catch (ex) {
-        throw ex;
       } finally {
         await indexerClient.deleteSkillset(skillSet);
       }